NoClobber WinCompat module import#12269
Merged
daxian-dbw merged 13 commits intoPowerShell:masterfrom Apr 16, 2020
Merged
Conversation
Collaborator
|
Do we want to have the fix as servicing one for 7.0 LTS? |
added 3 commits
April 7, 2020 11:32
14 tasks
Member
|
@PoshChan please retry windows |
Collaborator
|
@daxian-dbw, successfully started retry of |
added 4 commits
April 13, 2020 13:37
rjmholt
suggested changes
Apr 14, 2020
Collaborator
rjmholt
left a comment
There was a problem hiding this comment.
Generally looks good, but I think there are some cases with module specifications that need dealing with. Also left some style comments
src/System.Management.Automation/engine/Modules/ImportModuleCommand.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/Modules/ImportModuleCommand.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/Modules/ImportModuleCommand.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/Modules/ImportModuleCommand.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/Modules/ImportModuleCommand.cs
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Core/CompatiblePSEditions.Module.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Core/CompatiblePSEditions.Module.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Core/CompatiblePSEditions.Module.Tests.ps1
Show resolved
Hide resolved
SteveL-MSFT
requested changes
Apr 14, 2020
src/System.Management.Automation/engine/Modules/ImportModuleCommand.cs
Outdated
Show resolved
Hide resolved
added 2 commits
April 14, 2020 17:53
Author
|
@PoshChan please retry windows |
Collaborator
|
@anmenaga, successfully started retry of |
rjmholt
approved these changes
Apr 15, 2020
SteveL-MSFT
approved these changes
Apr 16, 2020
daxian-dbw
approved these changes
Apr 16, 2020
|
🎉 Handy links: |
This was referenced Apr 23, 2020
|
🎉 Handy links: |
silijon
pushed a commit
to SkyKick/PowerShell
that referenced
this pull request
Jul 2, 2020
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #11419
This addresses an issue where Windows PowerShell proxy modules have a priority over PS Core modules during WinCompat module import. (see #11419 )
PR Context
Implicit PS Remoting code (reused by WinCompat) is doing
Export-PSSession -AllowClobber.The fix is to omit
-AllowClobberparameter if WinCompat:engine modules:powershell.config.jsoninWindowsPowerShellCompatibilityNoClobberModuleListlist. (this list is empty by default)If a module falls into one of these buckets, then PS-Core version of the module is imported first (for
engine modulesfrom$PSHOME\Modules), then proxies are generated for WinPS version of the module without-AllowClobberflag. This result s in proxy modules not having PS Core commands.Fix #11419
Fix #12014
Also fixed a bug where WinCompat module DenyList was not working for module names containing dots
.in some cases.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.