Add CommandLine property to Process#12288
Add CommandLine property to Process#12288adityapatwardhan merged 2 commits intoPowerShell:masterfrom
Conversation
|
@iSazonov can you give a before and after for a perf comparison? Call The test can be as simple as: Measure-command { 1..100 | % { get-process } } |
|
@adityapatwardhan It is "on demand" property - you evaluate it only if you explicitly call the property. But if you call you get a slowdown. It is not in default output so users don't see slowdown in common scenarios. |
|
For both Linux and macOS, I wonder if it would be ok to run |
|
Using |
|
@TravisEz13 @JamesWTruher Do you know of a macOS workaround for this? |
|
@iSazonov I am not sure if we should take this PR without having a solution for all platforms. This introduces gotchas and makes cross platform scripting difficult. @iSazonov @SteveL-MSFT - thoughts? |
|
My plan is to open a tracking issue for MacOs. We have a lot of time before release and can investigate how enhance the feature on MacOs. |
|
The APIs will probably require some native coding on the mac. We can probably use the same apis as https://opensource.apple.com/source/top/top-111.20.1/libtop.c.auto.html |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
@iSazonov Please open a tracking bug for macOS and also open a issue for documentation as per the PR template. |
|
@adityapatwardhan Tracking issue #12832 As for doc issue - do we really need to document this? It seems we haven't docs for extended properties at all. |
|
@iSazonov No, we don't document the extended properties. But this is worth adding to the release notes. |
|
@iSazonov Thank you for your contribution! |
|
🎉 Handy links: |
PR Summary
Fix #3322 on Windows and Linux. For MacOs we will open new tracking issue to implement later.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.