Codestin Search App

iSazonov · 2020-04-17T17:04:06Z

PR Summary

Turn on ReadyToRun for PowerShell dll-s.

We can use dotnet/runtime#35062 (comment) to check dll-s.

PR Context

Now all .Net dll-s is in ReadyToRun format and PowerShell distributive doubled in size. So we can turn on the feature too. It will add ~20Mb (10%).

Docs https://docs.microsoft.com/en-us/dotnet/core/whats-new/dotnet-core-3-0#readytorun-images

PR Checklist

TravisEz13 · 2020-04-17T23:10:21Z

We should disable the crossgen, but only for our binaries... let me see if I can do this change...

TravisEz13 · 2020-04-17T23:48:40Z

I need to do some testing.

TravisEz13 · 2020-04-17T23:48:55Z

@daxian-dbw FYI

iSazonov · 2020-04-18T06:44:26Z

build.psm1

It seems we should disable Start-CrossGen function.

We should probably disable Start-CrossGen until we can verify PublishReadyToRun is a good replacement

CrossGen and ReadyToRun are the same thing, well, it's a switch to crossgen.

We can use set COMPlus_ReadyToRunLogFile=log.txt from issue I referenced above to check dll-s. Start-CrossGen does not create R2R dll-s.

@iSazonov crossgen with a switch is what is used to generate readytorun binaries in the dotnet project

And I switched us to that method, but per DotNet we need to use the csproj if we want our symbols to work: https://github.com/PowerShell/PowerShell/blob/master/build.psm1#L2217

But can your explain why crossgen should be disabled on the rest of the binaries?

I forgot that we also crossgen assemblies not part of the build that we include in the package. We should probably still crossgen those.

This make sense for third-party assemblies. For PSReadline and MI we could move to R2R format.

@iSazonov crossgen with a switch is what is used to generate readytorun binaries in the dotnet project

With set COMPlus_ReadyToRunLogFile=log.txt logs show that after Start-CrossGen our dll-s are not initialized as R2R but with PublishReadyToRun are initialized.

TravisEz13 · 2020-04-20T17:58:57Z

build.psm1

-        Write-Log "Run ResGen (generating C# bindings for resx files)"
-        Start-ResGen
-    }
+    # TODO: remove Start-ResGen after testing ReadyToRun


Please revert this change. This is the wrong PR

Oops, sorry.

This reverts commit 948b5f8.

daxian-dbw · 2020-04-20T18:44:00Z

Revert "Disable Start-ResGen"
Disable Start-CrossGen

@iSazonov You reverted a commit and then applied the same commit again.

TravisEz13 · 2020-04-22T18:05:18Z

build.psm1

        )

+        # TODO: remove Start-CrossGen after testing ReadyToRun.
+        return


This isn't true, and we should still crossgen the un-optimized binaries.

TravisEz13

Please address changes. I made ALL the needed changes the the crossgen function. Please revert back to my commit.

build.psm1

TravisEz13 · 2020-04-22T18:12:19Z

@PoshChan Please remind me in 1 hour

TravisEz13 · 2020-04-22T18:13:50Z

If we need to disable crossgen on the other assemblies, please submit a separate PR. Combining items in PRs makes it difficult if we need to backport.

PoshChan · 2020-04-22T19:12:46Z

@TravisEz13, this is the reminder you requested 1 hour ago

iSazonov · 2020-04-23T03:54:10Z

If we need to disable crossgen on the other assemblies, please submit a separate PR. Combining items in PRs makes it difficult if we need to backport.

I have only question about PSRL and MI. We could make it readytorun in their repos. If yes I can open tracking issues. Thoughts?

TravisEz13 · 2020-04-24T21:00:48Z

I think it's bad practices in publish the readytorun in the nuget. But I would open a new issue, and just be sure to ask that question.

TravisEz13 · 2020-04-24T21:17:07Z

"At present, libraries can only be R2R compiled as part of an application, not for delivery as a NuGet package."
https://devblogs.microsoft.com/dotnet/announcing-net-core-3-0-preview-6/

.NET Blog
Announcing .NET Core 3.0 Preview 6 | .NET Blog
Today, we are announcing .NET Core 3.0 Preview 6. It includes updates for compiling assemblies for improved startup, optimizing applications for size with linker and EventPipe improvements. We’ve also released new Docker images for Alpine on ARM64. Download .NET Core 3.0 Preview 6 right now on Windows,

iSazonov · 2020-04-25T05:47:18Z

In our publish folder we get .Net dll-s in R2R format and trace shows this. If we compiled them locally into this format, then PSRL and MI would also be converted in it. Yes? It makes me think that we get them already in R2R format and I'd expect we could get PSRL and MI in R2R format too.
I can ask in .Net repo but I do still not understand that ask. :-)

ghost · 2020-05-19T18:07:57Z

🎉v7.1.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

iSazonov added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 17, 2020

iSazonov added this to the 7.1.0-preview.2 milestone Apr 17, 2020

iSazonov requested review from SteveL-MSFT, TravisEz13, adityapatwardhan and daxian-dbw April 17, 2020 17:04

iSazonov requested a review from anmenaga as a code owner April 17, 2020 17:04

ghost assigned adityapatwardhan Apr 17, 2020

TravisEz13 assigned TravisEz13 and unassigned adityapatwardhan Apr 17, 2020

TravisEz13 modified the milestones: 7.1.0-preview.2, 7.0.x-Servicing-Consider Apr 17, 2020

TravisEz13 approved these changes Apr 17, 2020

View reviewed changes

iSazonov commented Apr 18, 2020

View reviewed changes

iSazonov and others added 2 commits April 18, 2020 11:55

Turn on ReadyToRun

e9acd1e

on crossgen non-PowerShell binaries

85fe743

iSazonov force-pushed the turn-on-readytorun branch from 34ce76f to 85fe743 Compare April 18, 2020 06:55

Disable Start-ResGen

948b5f8

TravisEz13 requested changes Apr 20, 2020

View reviewed changes

ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Apr 20, 2020

iSazonov added 2 commits April 20, 2020 23:03

Revert "Disable Start-ResGen"

c8e33d0

This reverts commit 948b5f8.

Disable Start-CrossGen

fd7bac4

Revert ResGen

9b264a9

TravisEz13 reviewed Apr 22, 2020

View reviewed changes

TravisEz13 requested changes Apr 22, 2020

View reviewed changes

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 22, 2020

TravisEz13 reviewed Apr 22, 2020

View reviewed changes

build.psm1 Outdated Show resolved Hide resolved

Make crossgen code work as expected

86a53e4

TravisEz13 approved these changes Apr 22, 2020

View reviewed changes

TravisEz13 removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Apr 22, 2020

TravisEz13 changed the title ~~Turn on ReadyToRun~~ Turn on ReadyToRun Apr 22, 2020

TravisEz13 merged commit 5cd89a4 into PowerShell:master Apr 22, 2020

iSazonov deleted the turn-on-readytorun branch April 23, 2020 03:51

adityapatwardhan mentioned this pull request Apr 23, 2020

Disable PublishReadyToRun for framework dependent packages #12450

Merged

14 tasks

Conversation

iSazonov commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

TravisEz13 commented Apr 17, 2020

Uh oh!

TravisEz13 commented Apr 17, 2020

Uh oh!

TravisEz13 commented Apr 17, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TravisEz13 Apr 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daxian-dbw commented Apr 20, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TravisEz13 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TravisEz13 commented Apr 22, 2020

Uh oh!

TravisEz13 commented Apr 22, 2020

Uh oh!

PoshChan commented Apr 22, 2020

Uh oh!

iSazonov commented Apr 23, 2020

Uh oh!

TravisEz13 commented Apr 24, 2020

Uh oh!

TravisEz13 commented Apr 24, 2020 • edited by unfurl-links bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iSazonov commented Apr 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented May 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

iSazonov commented Apr 17, 2020 •

edited

Loading

TravisEz13 Apr 20, 2020 •

edited

Loading

TravisEz13 commented Apr 24, 2020 •

edited by unfurl-links bot

Loading

iSazonov commented Apr 25, 2020 •

edited

Loading