Use correct casing for cmdlet name and cmdlet parameter name in *.ps1 files#12584
Merged
iSazonov merged 5 commits intoPowerShell:masterfrom May 7, 2020
Merged
Use correct casing for cmdlet name and cmdlet parameter name in *.ps1 files#12584iSazonov merged 5 commits intoPowerShell:masterfrom
iSazonov merged 5 commits intoPowerShell:masterfrom
Conversation
iSazonov
reviewed
May 6, 2020
Collaborator
iSazonov
left a comment
There was a problem hiding this comment.
Compare operators should be in low case.
test/powershell/Modules/Microsoft.PowerShell.Management/Rename-Item.Tests.ps1
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Management/Rename-Item.Tests.ps1
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Management/Rename-Item.Tests.ps1
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Security/CmsMessage2.Tests.ps1
Show resolved
Hide resolved
…-Item.Tests.ps1 Co-authored-by: Ilya <[email protected]>
iSazonov
approved these changes
May 6, 2020
Collaborator
|
@xtqqczze In future please make one change per commit - this greatly speeds up a code review. Also it would be nice to have static tests for this to exclude regressions in formatting (not in the PR). |
iSazonov
approved these changes
May 7, 2020
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PSUseCorrectCasingrule.demos\DSC\dsc-demo.ps1, see PSUseCorrectCasing malfunctioning in DSC configuration PSScriptAnalyzer#1474PR Context
PSScriptAnalyzer v1.19.0 introduces Cmdlet parameter name casing.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.