Codestin Search App

vexx32 · 2020-05-12T02:07:08Z

PR Summary

Added a few special cases and specific casting methods for BigInteger in LanguagePrimitives' casting methods and cached conversions.

Specific conversion paths for boolean & nulls were added, and conversions added to the cache. Also, some existing conversion paths were modified to add special cases for BigInteger, which are needed because it's not IConvertible like other numeric types are.

Fixes #12623

PR Context

These changes were split from #11634 and will fix #12623.

PR Checklist

iSazonov · 2020-05-12T03:21:23Z

src/System.Management.Automation/engine/LanguagePrimitives.cs

My ask dotnet/runtime#36264

I'm curious as to their response, but I think it's unlikely it'll change overall. If BigInteger gets to be IConvertible, sooner or later someone's gonna come along and ask if System.Numerics.Complex should be as well, and... let's just say I'll be watching that debate from the sidelines. 😂 🍿

src/System.Management.Automation/engine/LanguagePrimitives.cs

ghost · 2020-05-27T02:00:35Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

iSazonov · 2020-05-29T10:25:41Z

@daxian-dbw Please review.

ghost · 2020-07-07T02:00:12Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

iSazonov · 2020-07-22T14:04:45Z

Reopen to update CIs.

vexx32 · 2020-07-22T15:23:10Z

I probably need to rebase this... will have a look this afternoon :)

ghost · 2020-07-30T02:00:24Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

daxian-dbw · 2020-08-03T17:24:05Z

I apologize for not being able to review this in time. There are a few other @vexx32's and @iSazonov's PRs that we intended to get to but just couldn't yet ☹️ I will get to this one today.

Added a few special cases and specific casting methods for BigInteger in LanguagePrimitives' casting methods and cached conversions. Fixes PowerShell#12623

daxian-dbw

LGTM with a minor comment.

src/System.Management.Automation/engine/LanguagePrimitives.cs

Co-authored-by: Ilya <[email protected]>

daxian-dbw

Perfect, thanks! I appreciate your patience!

iSazonov · 2020-08-04T05:44:31Z

😺 Could add cognac labels 🍷 :

if PR waits one month - one start
if PR waits 3 months - two starts
and so on

daxian-dbw · 2020-08-04T16:13:31Z

if PR waits one month - one start
if PR waits 3 months - two starts

Or use angry face 😠 instead

iSazonov · 2020-08-04T16:18:48Z

Or use angry face 😠 instead

It is already reserved for user's Issues about bugs. :-)

ghost · 2020-08-17T22:20:52Z

🎉v7.1.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

ghost assigned iSazonov May 12, 2020

vexx32 mentioned this pull request May 12, 2020

Fix String Parameter Binding for Biginteger numeric literals #11634

Merged

14 tasks

iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label May 12, 2020

iSazonov added this to the 7.1.0-preview.3 milestone May 12, 2020

iSazonov requested a review from daxian-dbw May 12, 2020 03:10

vexx32 force-pushed the BigIntConversions branch from f0f6880 to 89480fd Compare May 12, 2020 03:22

iSazonov reviewed May 12, 2020

View reviewed changes

PoshChan reviewed May 12, 2020

View reviewed changes

src/System.Management.Automation/engine/LanguagePrimitives.cs Outdated Show resolved Hide resolved

PoshChan reviewed May 12, 2020

View reviewed changes

src/System.Management.Automation/engine/LanguagePrimitives.cs Outdated Show resolved Hide resolved

PoshChan reviewed May 12, 2020

View reviewed changes

src/System.Management.Automation/engine/LanguagePrimitives.cs Outdated Show resolved Hide resolved

PoshChan reviewed May 12, 2020

View reviewed changes

src/System.Management.Automation/engine/LanguagePrimitives.cs Outdated Show resolved Hide resolved

PoshChan reviewed May 12, 2020

View reviewed changes

src/System.Management.Automation/engine/LanguagePrimitives.cs Outdated Show resolved Hide resolved

PoshChan reviewed May 12, 2020

View reviewed changes

src/System.Management.Automation/engine/LanguagePrimitives.cs Outdated Show resolved Hide resolved

vexx32 force-pushed the BigIntConversions branch from 216d34f to 4d8b14d Compare May 12, 2020 12:36

PoshChan reviewed May 12, 2020

View reviewed changes

src/System.Management.Automation/engine/LanguagePrimitives.cs Outdated Show resolved Hide resolved

iSazonov mentioned this pull request May 12, 2020

BigInteger is not IConvertible dotnet/runtime#36264

Closed

vexx32 force-pushed the BigIntConversions branch from 4d8b14d to d0913e3 Compare May 12, 2020 22:27

PoshChan reviewed May 12, 2020

View reviewed changes

src/System.Management.Automation/engine/LanguagePrimitives.cs Outdated Show resolved Hide resolved

PoshChan reviewed May 12, 2020

View reviewed changes

src/System.Management.Automation/engine/LanguagePrimitives.cs Outdated Show resolved Hide resolved

PoshChan reviewed May 12, 2020

View reviewed changes

src/System.Management.Automation/engine/LanguagePrimitives.cs Outdated Show resolved Hide resolved

vexx32 force-pushed the BigIntConversions branch 2 times, most recently from 8851360 to 1ef8c98 Compare May 13, 2020 02:28

iSazonov reviewed May 13, 2020

View reviewed changes

vexx32 force-pushed the BigIntConversions branch from 1ef8c98 to fc6184b Compare May 13, 2020 06:17

TravisEz13 modified the milestones: 7.1.0-preview.3, 7.1.0-preview.4 May 14, 2020

ghost added the Review - Needed The PR is being reviewed label May 27, 2020

iSazonov approved these changes May 29, 2020

View reviewed changes

vexx32 mentioned this pull request Jul 20, 2020

Number literals: parse integer values too large to fit into Decimal as BigInteger (bigint), not Double #13212

Closed

iSazonov closed this Jul 22, 2020

ghost removed the Review - Needed The PR is being reviewed label Jul 22, 2020

iSazonov reopened this Jul 22, 2020

ghost added the Review - Needed The PR is being reviewed label Jul 30, 2020

ghost removed the Review - Needed The PR is being reviewed label Aug 3, 2020

vexx32 added 2 commits August 3, 2020 14:06

✅ Add conversion tests

07812fc

🐛 Improve biginteger casting behaviours

cb1ac80

Added a few special cases and specific casting methods for BigInteger in LanguagePrimitives' casting methods and cached conversions. Fixes PowerShell#12623

vexx32 force-pushed the BigIntConversions branch from fc6184b to cb1ac80 Compare August 3, 2020 18:06

daxian-dbw approved these changes Aug 4, 2020

View reviewed changes

src/System.Management.Automation/engine/LanguagePrimitives.cs Outdated Show resolved Hide resolved

♻️ Address review comment

f762c57

iSazonov reviewed Aug 4, 2020

View reviewed changes

src/System.Management.Automation/engine/LanguagePrimitives.cs Outdated Show resolved Hide resolved

♻️ Accept code review suggestion

90f1e37

Co-authored-by: Ilya <[email protected]>

daxian-dbw approved these changes Aug 4, 2020

View reviewed changes

iSazonov merged commit 6aa08f9 into PowerShell:master Aug 4, 2020

iSazonov added this to the 7.1.0-preview.7 milestone Aug 4, 2020

vexx32 deleted the BigIntConversions branch August 4, 2020 13:19

TravisEz13 modified the milestones: 7.1.0-preview.7, 7.1.0-preview.6 Aug 5, 2020

ghost mentioned this pull request Aug 17, 2020

BigInteger casting issues #12623

Closed

Conversation

vexx32 commented May 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

iSazonov May 12, 2020

Choose a reason for hiding this comment

Uh oh!

vexx32 May 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented May 27, 2020

Uh oh!

iSazonov commented May 29, 2020

Uh oh!

ghost commented Jul 7, 2020

Uh oh!

iSazonov commented Jul 22, 2020

Uh oh!

vexx32 commented Jul 22, 2020

Uh oh!

ghost commented Jul 30, 2020

Uh oh!

daxian-dbw commented Aug 3, 2020

Uh oh!

daxian-dbw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

daxian-dbw left a comment

Choose a reason for hiding this comment

Uh oh!

iSazonov commented Aug 4, 2020

Uh oh!

daxian-dbw commented Aug 4, 2020

Uh oh!

iSazonov commented Aug 4, 2020

Uh oh!

ghost commented Aug 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vexx32 commented May 12, 2020 •

edited

Loading

vexx32 May 12, 2020 •

edited

Loading