Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update to dotnet SDK 5.0.0-preview.5.20268.9#12740

Merged
3 commits merged intoPowerShell:masterfrom
JamesWTruher:dotnet5update002
May 21, 2020
Merged

Update to dotnet SDK 5.0.0-preview.5.20268.9#12740
3 commits merged intoPowerShell:masterfrom
JamesWTruher:dotnet5update002

Conversation

@JamesWTruher
Copy link
Collaborator

PR Summary

Update to dotnet SDK 5.0.0-preview.5.20268.9

PR Context

PR Checklist

@@ -1,5 +1,5 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesWTruher, your last commit had 1 failures in PowerShell-CI-windows
Enter-PSHostProcess tests.By Process Id.Can enter using NamedPipeConnectionInfo

Expected $true, but got $false.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Core\Enter-PSHostProcess.Tests.ps1: line 148
148:                     Should -BeTrue -Because (Get-Content $splat.FilePath -Raw)

@@ -1,5 +1,5 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesWTruher, your last commit had 1 failures in PowerShell-CI-windows
Enter-PSHostProcess tests.By Process Id.Can enter using NamedPipeConnectionInfo

Expected $true, but got $false.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Core\Enter-PSHostProcess.Tests.ps1: line 148
148:                     Should -BeTrue -Because (Get-Content $splat.FilePath -Raw)

@adityapatwardhan
Copy link
Member

@PoshChan please retry windows

@PoshChan
Copy link
Collaborator

@adityapatwardhan, successfully started retry of PowerShell-CI-Windows

@@ -1,5 +1,5 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesWTruher, your last commit had 1 failures in PowerShell-CI-windows
Enter-PSHostProcess tests.By Process Id.Can enter using NamedPipeConnectionInfo

Expected $true, but got $false.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Core\Enter-PSHostProcess.Tests.ps1: line 148
148:                     Should -BeTrue -Because (Get-Content $splat.FilePath -Raw)

@adityapatwardhan
Copy link
Member

@PoshChan please retry windows

@PoshChan
Copy link
Collaborator

@adityapatwardhan, successfully started retry of PowerShell-CI-Windows

@@ -1,5 +1,5 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesWTruher, your last commit had 1 failures in PowerShell-CI-windows
Enter-PSHostProcess tests.By Process Id.Can enter using NamedPipeConnectionInfo

Expected $true, but got $false.
at <ScriptBlock>, D:\a\1\s\test\powershell\Modules\Microsoft.PowerShell.Core\Enter-PSHostProcess.Tests.ps1: line 148
148:                     Should -BeTrue -Because (Get-Content $splat.FilePath -Raw)

@adityapatwardhan
Copy link
Member

@JamesWTruher can you have a look at the test failure? The test is known to be fragile but always passes on retry. It failed 2 retries on this PR.

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label May 21, 2020
@TravisEz13 TravisEz13 added this to the 7.1.0-preview.4 milestone May 21, 2020
@adityapatwardhan adityapatwardhan added the AutoMerge informs the bot to automerge the PR label May 21, 2020
@ghost
Copy link

ghost commented May 21, 2020

Hello @adityapatwardhan!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 24 hours, a condition that will be fulfilled in about 2 hours 38 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 05e682a into PowerShell:master May 21, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

@JamesWTruher JamesWTruher deleted the dotnet5update002 branch May 11, 2022 18:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge informs the bot to automerge the PR CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants