Add GitHub action for PR creation and Wix file generation logic#12748
Merged
adityapatwardhan merged 6 commits intoPowerShell:masterfrom May 22, 2020
Merged
Add GitHub action for PR creation and Wix file generation logic#12748adityapatwardhan merged 6 commits intoPowerShell:masterfrom
adityapatwardhan merged 6 commits intoPowerShell:masterfrom
Conversation
TravisEz13
reviewed
May 21, 2020
TravisEz13
reviewed
May 21, 2020
TravisEz13
approved these changes
May 21, 2020
TravisEz13
approved these changes
May 21, 2020
PoshChan
reviewed
May 21, 2020
5468c90 to
47a8f03
Compare
TravisEz13
approved these changes
May 22, 2020
TravisEz13
approved these changes
May 22, 2020
Member
Author
|
@PoshChan Please remind me in 1 hour |
Collaborator
|
@adityapatwardhan, this is the reminder you requested 1 hour ago |
Contributor
|
@adityapatwardhan This seems to create a PR for each fork and is going to create a lot of noise, is it possible to be opt-in or apply only to the PowerShell organisation itself? |
14 tasks
Member
Author
|
@bergmeister Thank you for finding this and creating a PR for the fix. |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
When we update to a new version of .NET we need to update the files.wxs file as well. This change automates that. The script needs to be run on Windows for that though.
Also add GitHub Action to create PR when there is an update, scheduled for 13:00 UTC. (6 AM PST now)
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.