Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use t_ naming convention for ThreadStatic members#12826

Merged
1 commit merged intoPowerShell:masterfrom
xtqqczze:ThreadStatic-naming
May 29, 2020
Merged

Use t_ naming convention for ThreadStatic members#12826
1 commit merged intoPowerShell:masterfrom
xtqqczze:ThreadStatic-naming

Conversation

@xtqqczze
Copy link
Contributor

PR Summary

PR Context

Violations of naming convention were found during #12820

PR Checklist

@xtqqczze xtqqczze requested a review from daxian-dbw as a code owner May 28, 2020 12:44
@ghost ghost assigned TravisEz13 May 28, 2020
@xtqqczze xtqqczze mentioned this pull request May 28, 2020
14 tasks
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label May 28, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.4 milestone May 28, 2020
@iSazonov iSazonov added the AutoMerge informs the bot to automerge the PR label May 28, 2020
@ghost
Copy link

ghost commented May 28, 2020

Hello @iSazonov!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 24 hours, a condition that will be fulfilled in about 22 hours 18 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 7b6e84d into PowerShell:master May 29, 2020
@xtqqczze xtqqczze deleted the ThreadStatic-naming branch May 29, 2020 15:20
@xtqqczze
Copy link
Contributor Author

xtqqczze commented May 30, 2020

If dotnet/roslyn#32955 is resolved, we could enforce the t_ convention using our .editorconfig.

@ghost
Copy link

ghost commented Jun 25, 2020

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge informs the bot to automerge the PR CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants