Expand numberOfPowershellRefAssemblies list capacity#12840
Merged
4 commits merged intoPowerShell:masterfrom Jun 2, 2020
Merged
Expand numberOfPowershellRefAssemblies list capacity#128404 commits merged intoPowerShell:masterfrom
4 commits merged intoPowerShell:masterfrom
Conversation
Member
|
@xtqqczze Please use a more descriptive PR title. |
Contributor
Author
|
This resolves the issue in #12815 (comment) but does not fix #12815 as it does not include a static test. |
Contributor
Author
|
@TravisEz13 can you help merge to resolve the breakage described in #12815 (comment) |
Collaborator
|
@TravisEz13 and @adityapatwardhan probably best to get this merged sooner than later; folks can't currently run debug builds at all while this is an issue. |
14 tasks
Contributor
Author
iSazonov
reviewed
Jun 1, 2020
src/Microsoft.PowerShell.Commands.Utility/commands/utility/AddType.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
The capacity is now 161 as per @iSazonov suggestion. |
Contributor
Author
|
@TravisEz13 ready to merge? |
iSazonov
reviewed
Jun 2, 2020
iSazonov
approved these changes
Jun 2, 2020
|
Hello @iSazonov! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Context
HEAD of master has been broken since 99da109 (#12772), when .NET was updated to 5.0.100-preview.5.20278.13
#12815 (comment)
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.