Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Fluent Design Icon asset for PowerShell 7 usage#13100

Merged
anmenaga merged 1 commit intoPowerShell:masterfrom
sar:master
Jul 7, 2020
Merged

Add Fluent Design Icon asset for PowerShell 7 usage#13100
anmenaga merged 1 commit intoPowerShell:masterfrom
sar:master

Conversation

@sar
Copy link

@sar sar commented Jul 4, 2020

PR Summary

Add a modern PowerShell icon with Fluent Design guidelines and inspired by the community. Retains the same design ethos and color palette, with a subtle new fluent approach. PR contains static svg asset.

PR Context

Asset Details

assets/ps_fluent_design_384.svg

Aspect Ratios

Example Bounding Box Usage: 512x512 or larger HiDPI 1:1
Icon Proportions: 384x240 8:5
Fun Fact: Icon is proportionally skewed at a 7-degree angle

Color Palletes

Grayscale: #FFFFFF, #000000
Gradient: [#2E466A 0%, #1C2C40 ~50%, #00040A 100%] 45 degrees top-left
Layout and color placement tested for Pinned Start Menu Tile, List Tile, Taskbar, rpm/deb Installer, MacOS Launchpad and Dock

Next Steps

Compile static assets in different sizes for dev/test in preview builds.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
  • Breaking changes
    • None: Static Assets only
  • Testing - New and feature
    • N/A or can only be tested interactively
  • Tooling
    • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.

@ghost ghost assigned anmenaga Jul 4, 2020
@ghost
Copy link

ghost commented Jul 4, 2020

CLA assistant check
All CLA requirements met.

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@TylerLeonhardt
Copy link
Member

Looks very clean :)

Personally, I think it's a bit too oblong along the X axis.

@TylerLeonhardt
Copy link
Member

I'm concerned people will confuse it with Windows Terminal because folks already do confuse terminal with shell

@SteveL-MSFT
Copy link
Member

My approval doesn't mean we'll switch to using this new logo. I do think it's good enough that we can build upon it.

@anmenaga anmenaga added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log and removed CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log labels Jul 7, 2020
@anmenaga anmenaga merged commit 6d7e30d into PowerShell:master Jul 7, 2020
@ghost
Copy link

ghost commented Aug 17, 2020

🎉v7.1.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants