Fix Invoke-History to detect recursive call of the same history entry#13197
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Jul 23, 2020
Merged
Fix Invoke-History to detect recursive call of the same history entry#13197daxian-dbw merged 1 commit intoPowerShell:masterfrom
Invoke-History to detect recursive call of the same history entry#13197daxian-dbw merged 1 commit intoPowerShell:masterfrom
Conversation
iSazonov
approved these changes
Jul 17, 2020
Collaborator
iSazonov
left a comment
There was a problem hiding this comment.
Please fix typo in title.
Invoke-History to detect recursive call of the same history entry
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #13183
Fix
Invoke-Historyto detect recursive invocation of history entries.The old loop detection seems depend on the history invocation runs in the same pipeline, but that's not the case any more (maybe changed in v5).
The fix is to move the
loop-detectionlogic to theHistoryclass. A Runspace holds aHistoryinstance, it's like a singleton in the Runspace scope. not really a singleton because a new instance will be used if you reset the Runspace, but there is only one instance per Runspace at a given time.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.