Thanks to visit codestin.com
Credit goes to github.com

Skip to content

SwitchParameter should be property not field#13291

Merged
rjmholt merged 1 commit intoPowerShell:masterfrom
xtqqczze:propertynotfield
Aug 6, 2020
Merged

SwitchParameter should be property not field#13291
rjmholt merged 1 commit intoPowerShell:masterfrom
xtqqczze:propertynotfield

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jul 27, 2020

PR Summary

SwitchParameter should always be a property, fields here look like errors as as the comments imply use of getter/setter.

PR Context

Technically breaking changes to public API, but "Bucket 3: Unlikely Grey Area".

Changes correct violations of CA1051: Do not declare visible instance fields.

PR Checklist

@rjmholt rjmholt added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 27, 2020
@rjmholt rjmholt added the Review - Needed The PR is being reviewed label Jul 28, 2020
@rjmholt rjmholt merged commit 87b2581 into PowerShell:master Aug 6, 2020
@xtqqczze xtqqczze deleted the propertynotfield branch August 6, 2020 22:36
@iSazonov iSazonov removed the Review - Needed The PR is being reviewed label Aug 7, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.6 milestone Aug 7, 2020
@ghost
Copy link

ghost commented Aug 17, 2020

🎉v7.1.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants