Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make the failing test pending to unblock PR CIs#13310

Merged
iSazonov merged 7 commits intoPowerShell:masterfrom
daxian-dbw:testpending
Jul 30, 2020
Merged

Make the failing test pending to unblock PR CIs#13310
iSazonov merged 7 commits intoPowerShell:masterfrom
daxian-dbw:testpending

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Jul 30, 2020

PR Summary

The test TraceRoute works in the context TraceRoute in the file Test-Connection.Tests.ps1 is causing timeout in macOS CI builds.

image

We will make the test pending to unblock PR CIs. Issue #13309 was filed to track the investigation.

PR Context

PR Checklist

@daxian-dbw daxian-dbw requested a review from rjmholt July 30, 2020 00:31
@rjmholt
Copy link
Collaborator

rjmholt commented Jul 30, 2020

@PoshChan please remind me in 1 hour

@daxian-dbw
Copy link
Member Author

@rjmholt Please merge once CIs passed, so that we can unblock other PR CIs.

@rjmholt
Copy link
Collaborator

rjmholt commented Jul 30, 2020

Looks like the macOS tests are still failing

@rjmholt
Copy link
Collaborator

rjmholt commented Jul 30, 2020

Looks like the macOS tests are still failing

Pushed a change to alleviate this

@rjmholt
Copy link
Collaborator

rjmholt commented Jul 30, 2020

@PoshChan please remind me in 1 hour

@PoshChan
Copy link
Collaborator

@rjmholt, this is the reminder you requested 1 hour ago

1 similar comment
@PoshChan
Copy link
Collaborator

@rjmholt, this is the reminder you requested 1 hour ago

@rjmholt
Copy link
Collaborator

rjmholt commented Jul 30, 2020

@PoshChan please remind me in 1 hour

@PoshChan
Copy link
Collaborator

@rjmholt, this is the reminder you requested 1 hour ago

@rjmholt
Copy link
Collaborator

rjmholt commented Jul 30, 2020

@PoshChan please remind me in 1 hour

@PoshChan
Copy link
Collaborator

@rjmholt, this is the reminder you requested 1 hour ago

@iSazonov iSazonov merged commit 1f904e4 into PowerShell:master Jul 30, 2020
@iSazonov iSazonov added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jul 30, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.7 milestone Jul 30, 2020
@daxian-dbw daxian-dbw deleted the testpending branch July 30, 2020 15:59
@daxian-dbw
Copy link
Member Author

@rjmholt Thanks!

@TravisEz13 TravisEz13 modified the milestones: 7.1.0-preview.7, 7.1.0-preview.6 Aug 5, 2020
@ghost
Copy link

ghost commented Aug 17, 2020

🎉v7.1.0-preview.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants