Fix Get-Help not properly displaying if parameter supports wildcards#13353
Merged
adityapatwardhan merged 4 commits intoPowerShell:masterfrom Aug 11, 2020
Merged
Conversation
Member
|
@ThomasNieto This looks great! Could you add a before v/s after of the output in the description. |
Contributor
Author
|
@adityapatwardhan Sure, its been added. |
Contributor
Author
|
@adityapatwardhan think you'll be able to merge today so I can start work on #2490? 😄 |
adityapatwardhan
approved these changes
Aug 6, 2020
adityapatwardhan
requested changes
Aug 6, 2020
14 tasks
Contributor
Author
|
@adityapatwardhan are there anymore changes needed before merging? |
adityapatwardhan
approved these changes
Aug 11, 2020
Member
|
@ThomasNieto Thank you for your contribution! |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR is to fix the issue with
Get-Helpnot properly displaying if a parameter supports wildcards when a script cmdlet has no comment-based help.Before
After
PR Context
This PR solves the code issue with #4716 but not the other part of adding
[SupportsWildcards]attribute to the identified cmdlets. That will be fixed in another PR.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.