Add missing dispose for CancellationTokenSource#13420
Merged
anmenaga merged 2 commits intoPowerShell:masterfrom Aug 13, 2020
Merged
Add missing dispose for CancellationTokenSource#13420anmenaga merged 2 commits intoPowerShell:masterfrom
anmenaga merged 2 commits intoPowerShell:masterfrom
Conversation
Contributor
|
A useful tool for work like this is: IDisposableAnalyzers (alpha release). |
rjmholt
approved these changes
Aug 12, 2020
iSazonov
approved these changes
Aug 13, 2020
| } | ||
|
|
||
| _cimSensitiveValueConverter.Dispose(); | ||
| _cancellationTokenSource.Dispose(); |
Collaborator
There was a problem hiding this comment.
This comes from Windows PowerShell.
@rjmholt your team could internally consider a backport.
Collaborator
|
@Youssef1313 Thanks for your contribution! |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dispose()call was missing on CancellationTokenSource in CimChildJobBase and TestConnectionCommand.