Merged
Conversation
vexx32
reviewed
Aug 21, 2020
PaulHigin
suggested changes
Aug 21, 2020
Contributor
PaulHigin
left a comment
There was a problem hiding this comment.
I prefer the original fix. It is more readable than the with null coalescing.
Contributor
Author
|
@PaulHigin I don't mind reverting the second commit, but I'm unsure who makes the final decision in this, and I'd like to avoid going back and forth between the two variants. Is it @iSazonov who decides in the end? |
Collaborator
|
@tamasvajk I like first commit more too as more readable in the assert context. |
This reverts commit 08647e7.
Contributor
Author
|
@iSazonov thank you for the confirmation. I reverted the second commit. |
iSazonov
approved these changes
Aug 24, 2020
PaulHigin
approved these changes
Aug 26, 2020
Collaborator
|
@tamasvajk Thanks for your contribution! |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.