Update to .NET 5 preview 8#13530
Conversation
| <ProjectReference Include="..\Microsoft.Management.UI.Internal\Microsoft.PowerShell.GraphicalHost.csproj" Condition="'$(SDKToUse)' == 'Microsoft.NET.Sdk.WindowsDesktop' "/> | ||
| </ItemGroup> | ||
|
|
||
| <Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk" /> |
There was a problem hiding this comment.
Shall we move this above next to <Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" />?
There was a problem hiding this comment.
We can try, but this was the recommendation from the .NET team member.
| <AssemblyName>Microsoft.PowerShell.GraphicalHost</AssemblyName> | ||
| <UseWPF>True</UseWPF> | ||
| <TargetPlatformIdentifier>Windows</TargetPlatformIdentifier> | ||
| <TargetPlatformVersion>7.0</TargetPlatformVersion> |
There was a problem hiding this comment.
Just curious, what does the TargetPlatformVersion mean? Meaning targeting win-7?
There was a problem hiding this comment.
Yes, that is the OS version
There was a problem hiding this comment.
We might have to have separate Win7 and Win10 packages as I think it's required to set this to 10 to pull in the WinRT packages
There was a problem hiding this comment.
Can we try setting this to 10 in a private branch and see if that helps the WinRT issue?
There was a problem hiding this comment.
I'm doing a local build to verify this
There was a problem hiding this comment.
I think it is too late in the release to generate 2 packages for windows. We should do that for 7.2 if needed.
|
Waiting on the wix file to generate |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Dongbo Wang <[email protected]>
|
🎉 Handy links: |
PR Summary
Updates our .NET SDK dependency to 5-preview.8.
Also fixes issues with csproj files for powershell-win-core and GraphicalHost that blocked this update.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.