Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add GitHub Workflow to keep notices up to date #16284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 14 commits into from
Oct 28, 2021
Merged

Add GitHub Workflow to keep notices up to date #16284

TravisEz13 merged 14 commits into from
Oct 28, 2021

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Oct 20, 2021 •
edited
Loading

PR Summary

Add GitHub Workflow to keep notices up to date:

  1. Update notices from the latest daily compliance build
  2. Update the cgnotices for any packages missing from the notices file

PR Context

PR Checklist

@ghost ghost assigned iSazonov Oct 20, 2021
@TravisEz13 TravisEz13 changed the title Add GitHub Workflow to keep cgmanifest up to date Add GitHub Workflow to keep notices up to date Oct 21, 2021
@TravisEz13 TravisEz13 force-pushed the cgmanifest-GH-action branch from b00e25b to ac745d6 Compare October 22, 2021 17:34
rjmholt
rjmholt reviewed Oct 26, 2021
View reviewed changes
@TravisEz13 TravisEz13 force-pushed the cgmanifest-GH-action branch from 1bfa377 to 89e84dd Compare October 26, 2021 23:15
TravisEz13
TravisEz13 commented Oct 26, 2021
View reviewed changes
tools/buildCommon/buildCommon.psm1
Comment on lines 8 to 10
[Alias('sb')]
[Parameter(Mandatory=$true)]
[scriptblock]$ScriptBlock,
Copy link
Member Author

@TravisEz13 TravisEz13 Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for renaming this, and removing the script scope this is just a copy from build.psm1

@TravisEz13 TravisEz13 added MustHave Compliance Related to compliance requirements labels Oct 27, 2021
@daxian-dbw
Copy link
Member

daxian-dbw commented Oct 27, 2021

@TravisEz13 Please look into the failed CIs. Also, you need to resolve the conflicts in build.psm1.

@TravisEz13 TravisEz13 force-pushed the cgmanifest-GH-action branch from 89e84dd to 304646f Compare October 28, 2021 00:26
@TravisEz13
Copy link
Member Author

TravisEz13 commented Oct 28, 2021

failures were due to failures in master. Rebased to pick up a revert.

@TravisEz13 TravisEz13 force-pushed the cgmanifest-GH-action branch from 304646f to e95f0aa Compare October 28, 2021 17:45
@TravisEz13 TravisEz13 force-pushed the cgmanifest-GH-action branch from f121700 to 2ab02af Compare October 28, 2021 18:11
@TravisEz13 TravisEz13 merged commit f41b6b4 into master Oct 28, 2021
@TravisEz13 TravisEz13 deleted the cgmanifest-GH-action branch October 28, 2021 18:44
@TravisEz13 TravisEz13 mentioned this pull request Oct 28, 2021
Merged
22 tasks
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 28, 2021
@iSazonov iSazonov assigned TravisEz13 and unassigned iSazonov Oct 29, 2021
@ghost
Copy link

ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

TrapGodBrim pushed a commit to TrapGodBrim/PowerShell that referenced this pull request Jan 19, 2022
@TravisEz13 @rjmholt @TrapGodBrim
Add GitHub Workflow to keep notices up to date (PowerShell#16284)
8d21259 
Co-authored-by: Robert Holt <[email protected]>
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 14, 2022
@TravisEz13 @rjmholt
Add GitHub Workflow to keep notices up to date (PowerShell#16284)
de5453e 
Co-authored-by: Robert Holt <[email protected]>
# Conflicts:
#	build.psm1
#	tools/findMissingNotices.ps1
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 15, 2022
@TravisEz13
Add GitHub Workflow to keep notices up to date (PowerShell#16284)
899102c 
Co-authored-by: Robert Holt <[email protected]>
# Conflicts:
#	build.psm1
#	tools/findMissingNotices.ps1

# Conflicts:
#	build.psm1
@ghost
Copy link

ghost commented Mar 16, 2022

🎉v7.0.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Mar 16, 2022

🎉v7.1.6 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

+1 more reviewer

@rjmholt rjmholt rjmholt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

Backport-7.0.x-Done BackPort-7.1.x-Done Backport to 7.1.x completed CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Compliance Related to compliance requirements MustHave

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TravisEz13 @daxian-dbw @rjmholt @iSazonov