-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Do not include node names when sending telemetry. #16981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not include node names when sending telemetry. #16981
Conversation
This uses a telemetry initializer to obscure the node name when sending telemetry as setting it explicitly in the telemetry client does not work.
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
PaulHigin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
…owerShell#16981) to v7.2.3 Do not include node names when sending telemetry. (PowerShell#16981) PowerShell#16981
|
🎉 Handy links: |
PR Summary
This uses a telemetry initializer to obscure the node name when sending telemetry
as setting it explicitly in the telemetry client does not work.
PR Context
Addresses issue reported in Twitter where we're still reporting the name of the computer in the role instance.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).