Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@fflaten
Copy link
Contributor

@fflaten fflaten commented Jul 23, 2022

PR Summary

A progress-bar started in ActionPreference.Tests.ps1 is never completed and causes the the progress-bar to be rendered for all remaining tests including other files, killing the performance.

PR Context

tests-progressactivity

Demo command: Start-PSPester -SkipTestToolBuild -Path /workspaces/PowerShell/test/powershell/Language/Scripting/ActionPreference.Tests.ps1, /workspaces/PowerShell/test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1

Before change: 60-70s
After change: 16s

PR Checklist

@ghost ghost assigned daxian-dbw Jul 23, 2022
@fflaten
Copy link
Contributor Author

fflaten commented Jul 23, 2022

Related to #17516 ?

@iSazonov iSazonov added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jul 24, 2022
@daxian-dbw daxian-dbw merged commit f1595c4 into PowerShell:master Jul 25, 2022
@fflaten fflaten deleted the fix-tests branch July 25, 2022 18:22
@ghost
Copy link

ghost commented Aug 11, 2022

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants