Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use absolute path in FileSystemProvider.CreateDirectory #24615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 4 commits into from
May 13, 2025
+15 −7
Merged

Use absolute path in FileSystemProvider.CreateDirectory #24615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4092b3f
Remove unnecessary path split
Tadas Nov 23, 2024
2e3baf5
Update test to create new PSDrive
Tadas Jan 5, 2025
8694def
Rename test
Tadas Feb 9, 2025
99f3cd2
Update test/powershell/Modules/Microsoft.PowerShell.Management/FileSy…
Tadas May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/System.Management.Automation/namespaces/FileSystemProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2666,12 +2666,6 @@ private void CreateDirectory(string path, bool streamOutput)
!string.IsNullOrEmpty(path),
"The caller should verify path");

// Get the parent path
string parentPath = GetParentPath(path, null);

// The directory name
string childName = GetChildName(path);

ErrorRecord error = null;
if (!Force && ItemExists(path, out error))
{
Expand Down Expand Up @@ -2701,7 +2695,7 @@ private void CreateDirectory(string path, bool streamOutput)

if (ShouldProcess(resource, action))
{
var result = Directory.CreateDirectory(Path.Combine(parentPath, childName));
var result = Directory.CreateDirectory(path);

if (streamOutput)
{
Expand Down
14 changes: 14 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,6 +1205,20 @@ Describe "Extended FileSystem Item/Content Cmdlet Provider Tests" -Tags "Feature
$result.Name | Should -BeExactly $testDir
}

It "Verify Directory creation when path relative to current PSDrive is empty" {
try {
$rootDir = New-Item "NewDirectory" -ItemType Directory -Force
$rootPath = $rootDir.FullName
$newPSDrive = New-PSDrive -Name "NewPSDrive" -PSProvider FileSystem -Root $rootPath

$result = New-Item -Path "NewPSDrive:\" -ItemType Directory -Force
$result.FullName.TrimEnd("/\") | Should -BeExactly $newPSDrive.Root
}
finally {
Remove-PSDrive -Name "NewPSDrive" -Force -ErrorAction SilentlyContinue
}
}

It "Verify File + Value" {
$result = New-Item -Path . -ItemType File -Name $testFile -Value "Some String"
$content = Get-Content -Path $testFile
Expand Down
Loading