-
Notifications
You must be signed in to change notification settings - Fork 8.1k
[release/v7.4] Fix up SSHConnectionInfo ssh PATH checks #26167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/v7.4
Are you sure you want to change the base?
[release/v7.4] Fix up SSHConnectionInfo ssh PATH checks #26167
Conversation
…pace is not available (PowerShell#25780)
|
/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
First, we need to backport this to 7.5, but even then, I'm not sure this meets the bar for LTS backport. |
|
I really think more needs to go into what qualifies for a backport then. Like an official document in the repo. It seems like it’s whatever arbitrary decision made by the pwsh team. Sorry if it sounds rude but this is a pretty simple fix that has been waiting to be included in an official release for 5 months now. Even then this backport was opened 3 months ago and only now a decision/review over it has been made. I wouldn’t be pushing for a backport for bugfixes if we didn’t have to wait so long for anything. |
|
@jborean93 They should update most of the documents in this project, but I believe they are forced to follow the internal requirements of MSFT, which cannot be disclosed. This is a fundamental problem in this project. The situation seems to be better in .The Net Runtime project that is under .Net Foundation. PowerShell project probably should have followed this path. |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Backport of #25780 to release/v7.4
Triggered by @adityapatwardhan on behalf of @jborean93
Original CL Label: CL-Engine
/cc @PowerShell/powershell-maintainers
Impact
Choose either tooling or Customer impact.
Tooling Impact
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]