Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@TravisEz13
Copy link
Member

Backport of #26398 to release/v7.4

Triggered by @TravisEz13 on behalf of @TravisEz13

Original CL Label: CL-BuildPackaging

/cc @PowerShell/powershell-maintainers

Impact

Tooling Impact

  • Required tooling change

Improves ADO (Azure DevOps) package build and validation for macOS across platforms. Adds better diagnostic logging for artifact uploads and moves macOS package validation tests to a more appropriate location. These improvements help troubleshoot build issues on release branches.

Regression

  • Yes
  • No

This is a tooling/infrastructure improvement, not fixing a regression.

Testing

Original PR verified by:

  1. Running updated macOS package builds in ADO pipeline
  2. Validating improved logging output during artifact uploads
  3. Running relocated package validation tests
  4. Confirming builds complete successfully across x64 and arm64 architectures

Backport verified by:

  1. Successfully resolved merge conflicts in mac-package-build.yml
  2. Build logic adapted to release/v7.4 branch structure
  3. All changes preserve release branch patterns

Risk

  • High
  • Medium
  • Low

Medium risk: Changes build/packaging infrastructure and test locations, but improvements are valuable for maintaining build health on release branch. The enhanced logging helps diagnose issues faster. Changes have been validated in master branch and adapted appropriately for v7.4.

Merge Conflicts Resolution

Summary

One file had conflicts during cherry-pick due to code structure differences between branches.

Detailed Resolutions

File: .pipelines/templates/mac-package-build.yml

  • Lines: 133-151
  • Conflict: Release branch had simpler single-line artifact upload; main branch added verbose logging and foreach loops
  • Resolution: Accepted incoming changes from backport which add:
    • Verbose logging before package searches (Write-Verbose "Looking for ... packages...")
    • Foreach loops to upload each package file individually with verbose output
    • Better diagnostics for troubleshooting package build issues
  • Rationale: The improved logging and diagnostic output are valuable for troubleshooting builds on the release branch. No functional changes to package creation, only enhanced observability.

All resolutions verified by:

  • Successful cherry-pick completion
  • File changes aligned with original PR intent
  • No loss of release branch-specific code patterns

Copilot AI review requested due to automatic review settings November 7, 2025 23:57
@TravisEz13 TravisEz13 changed the base branch from master to release/v7.4 November 7, 2025 23:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Nov 9, 2025
@TravisEz13 TravisEz13 closed this Nov 10, 2025
@TravisEz13 TravisEz13 reopened this Nov 10, 2025
@TravisEz13 TravisEz13 merged commit 7a63d92 into PowerShell:release/v7.4 Nov 10, 2025
40 of 42 checks passed
@TravisEz13 TravisEz13 deleted the backport/release/v7.4/26398-e7bf5621b branch November 10, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants