Remove AddTypeCommandBase class#5407
Merged
iSazonov merged 2 commits intoPowerShell:masterfrom Nov 17, 2017
Merged
Conversation
Remove AddTypeCommandBase class. Minor code cleanups. Fix comments.
d347d8e to
0648dfc
Compare
Collaborator
Author
|
@daxian-dbw @SteveL-MSFT Can we review and merge before RC? - it is formally breaking change. |
Member
|
Although technically a breaking change, I think the risk is low that we can take it after 6.0.0 rather than delay the RC |
PaulHigin
suggested changes
Nov 15, 2017
|
|
||
| if (value != null) | ||
| { | ||
| String.Join("\n", value); |
Contributor
There was a problem hiding this comment.
It looks like this was never completed. Shouldn't this be:
sourceCode = String.Join("\n", value);
Then remove the loop.
PaulHigin
approved these changes
Nov 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #5158:
After the cleanups we can continue to improve Add-Type cmdlet.