Combine Web Cmdlet Partial Class Files#5612
Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom Dec 5, 2017
Merged
Conversation
Contributor
Author
|
@iSazonov let me know if this is easier to work with. |
Collaborator
|
Yes, it is more easy. I spent one hour to review the code. Thanks. |
Collaborator
|
Doc tests failed again on WMF links. I think we could run doc tests with separate test tag. And maybe run some tests on demand by test tag. |
Member
|
I restarted the mac tests, but they failed in webCmdLets. If they fail again, can you investigate @markekraus |
Contributor
Author
|
It looks like it has been too long since the last commit to restart the the CI. I will push an empty commit. |
Contributor
Author
|
@TravisEz13 all passing now :) |
Collaborator
|
😄 Our tests resemble a pinball machine in a casino. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference #5610
This moves the partial class into a single file each. This code is purposely not sorted and the formatting is left alone to make this easier to review. There are cleanup actions planned in the referenced Issue.