code coverage: Get GitCommitId using the ProductVersion from Assembly#5651
Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom Dec 8, 2017
Merged
Conversation
JamesWTruher
approved these changes
Dec 7, 2017
Member
|
Why are the two different? |
Member
Author
|
@TravisEz13 This is what we get currently on PSVersionTable: Name Value
---- -----
PSVersion 6.0.0-rc
PSEdition Core
GitCommitId v6.0.0-rc
OS Microsoft Windows 10.0.16299
Platform Win32NT
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
WSManStackVersion 3.0
We need a real commit ID so we can checkout. |
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Dec 9, 2017
TravisEz13
pushed a commit
that referenced
this pull request
Dec 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
We can no longer rely on
PSVersionTablefor the real Git commit Id. We can get it using the VersionInfo from System.Management.Automation.dll.PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affectes feature tests