Add Count and Length properties to [PSCustomobject]#5745
Merged
iSazonov merged 2 commits intoPowerShell:masterfrom Dec 28, 2017
Merged
Add Count and Length properties to [PSCustomobject]#5745iSazonov merged 2 commits intoPowerShell:masterfrom
iSazonov merged 2 commits intoPowerShell:masterfrom
Conversation
Add new tests
b927644 to
51b2a00
Compare
lzybkr
reviewed
Dec 26, 2017
| (10).Length | Should Be 1 | ||
|
|
||
| ("a").Count | Should Be 1 | ||
| ("a").Length | Should Be 1 |
Contributor
There was a problem hiding this comment.
The Length property exists for strings, so this isn't (shouldn't be) testing singletons.
lzybkr
reviewed
Dec 26, 2017
| ([psobject] @{ foo = 'bar' }).Length | Should Be 1 | ||
|
|
||
| ([pscustomobject] @{ foo = 'bar' }).Count | Should Be 1 | ||
| ([pscustomobject] @{ foo = 'bar' }).Length | Should Be 1 |
Contributor
There was a problem hiding this comment.
You should also test when a pscustomobject has a count or length property to make sure we return the correct value.
lzybkr
approved these changes
Dec 26, 2017
Contributor
lzybkr
left a comment
There was a problem hiding this comment.
Approved w/ a couple test suggestions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Related #3671
Now following works with singletons and returns 1:
([pscustomobject] @{ foo = 'bar' }).Count
([pscustomobject] @{ foo = 'bar' }).Length
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affectes feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.