Show usage (short) help if command line parameter is wrong#5780
Merged
iSazonov merged 2 commits intoPowerShell:masterfrom Jan 5, 2018
Merged
Show usage (short) help if command line parameter is wrong#5780iSazonov merged 2 commits intoPowerShell:masterfrom
iSazonov merged 2 commits intoPowerShell:masterfrom
Conversation
4 tasks
Collaborator
Author
|
CI AppVeyor temporary failed. |
SteveL-MSFT
requested changes
Jan 3, 2018
|
|
||
| https://aka.ms/pscore6-docs | ||
| Type 'help' to get help.</value> | ||
| </data> |
Member
There was a problem hiding this comment.
I don't like that we have a copy of the syntax. If we make updates in the future, we need to manually ensure that both sections are updated. Perhaps we can have the syntax (aka short help) just called HelpSyntax and the other one called ExtendedHelp. Now change the code where full help would have been shown shows HelpSyntax followed by ExtendedHelp.
Collaborator
Author
There was a problem hiding this comment.
If ExtendedHelp maybe second - UsageHelp or ShortHelp?
SteveL-MSFT
requested changes
Jan 4, 2018
| _hostUI.Write(_helpText); | ||
| if (_showExtendedHelp) | ||
| { | ||
| _hostUI.Write(ManagedEntranceStrings.ExtendedHelp); |
Member
There was a problem hiding this comment.
Shouldn't this show both UsageHelp and ExtendedHelp?
Collaborator
Author
There was a problem hiding this comment.
Line 396 already show UsageHelp.
SteveL-MSFT
approved these changes
Jan 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Close #4986
pwsh -hPR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affectes feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.