Windows installer: Allow Launch PowerShell checkbox to be toggled using the space bar (the Enter key already defaults to the Finish button)#5792
Conversation
…e Enter key already defaults to the `Finish`) button. Reuse product name variable
Launch PowerShell checkbox to be togged using the space bar (the Enter key already defaults to the Finish button)Launch PowerShell checkbox to be toggled using the space bar (the Enter key already defaults to the Finish button)
|
It works. But I caught another problem: I install current build PowerShell-6.1.0-preview.7428-win-x64.msi over previous PowerShell-6.1.0-preview.7420-win-x64.msi and lost the local Explorer menu for PowerShell 😕 |
|
@iSazonov : I cannot repro your problem. I installed
The only way to fulfill both cases would be to detect that it is an upgrade install and set the defaults to the current configuration. This might be quite difficult and error prone to implement. |
|
@bergmeister I would defer worrying about those cases until there is sufficient feedback we need to support it (whichever case) |
|
@bergmeister Never mind, I used non-rebased branch. |
PR Summary
Move definition of
Launch PowerShellcheckbox to the top to allow toggling it using the spacebar (the Enter key already defaults to theFinishbutton).This is quite common amongst best practice WiX installers to make it possible to navigate through the dialogs without having to touch the mouse. This behvaiour is the same as the licence dialogue that allows toggling the checkbox using the space bar as well,
This does not affect the visual appearance.
Also reuse product name variable
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affectes feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.