6.1.0. - Make explorer context menus platform specific to allow them to work when both x86 and x64 are installed#5824
Merged
iSazonov merged 1 commit intoPowerShell:masterfrom Jan 10, 2018
Conversation
…w side by side of x86 and x64. The main menu has a " (x86)" appended to the main menu. Some renaming of existing variables to distinguish between main menu and sub menu
iSazonov
approved these changes
Jan 9, 2018
Collaborator
iSazonov
left a comment
There was a problem hiding this comment.
LGTM but I don't check for x86.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Make explorer context menu registry entries platform specific to allow them to work also when both x86 and x64 are installed. The main menu has a " (x86)" appended to the main menu as well.
This issue was found a few days after the context menu was merged into master in an unrelated issue by @iSazonov
Some renaming was applied to existing variables to distinguish better between main menu and sub menu
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affects feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.