Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support running tests in root privilege on Linux. #6145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 17 commits into from
Feb 16, 2018
Merged

Support running tests in root privilege on Linux. #6145

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
13848a5
Adding Sudo parameter to Start-PSPester function.
kalgiz Feb 9, 2018
ee7227d
Running tests, which require sudo on Linux.
kalgiz Feb 9, 2018
466c8c7
Running tests on Linux which require Sudo.
kalgiz Feb 9, 2018
31fe5f1
Merge branch 'master' of https://github.com/kalgiz/PowerShell into i5645
kalgiz Feb 9, 2018
07ae3f7
Assigning parameter in the same Parameter Set as PassThru in Start-P…
kalgiz Feb 10, 2018
65b85d3
Correcting tag issues for tests run with sudo on Unix.
kalgiz Feb 13, 2018
e53399e
Merge branch 'master' of https://github.com/kalgiz/PowerShell into i5645
kalgiz Feb 13, 2018
42113a7
Correcting cmdlet in travis.ps1 file.
kalgiz Feb 13, 2018
e43ddfa
Correcting cmdlet in travis.ps1 file.
kalgiz Feb 13, 2018
0a7bdbb
Style corrections in build.ps1
kalgiz Feb 13, 2018
2130477
Merge branch 'master' of https://github.com/kalgiz/PowerShell into i5645
kalgiz Feb 13, 2018
573d91b
Deleting stale comment.
kalgiz Feb 13, 2018
a2db089
Updating test results files in travis.
kalgiz Feb 14, 2018
08736e3
Correcting paths to test results.
kalgiz Feb 14, 2018
b328b62
Adding the variable mark
kalgiz Feb 14, 2018
dc404aa
Use pass Thru objects in Test-PSPester results instead of output files
kalgiz Feb 15, 2018
554a23b
Merge branch 'master' of https://github.com/kalgiz/PowerShell into i5645
kalgiz Feb 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updating test results files in travis.
  • Loading branch information
@kalgiz
kalgiz committed Feb 14, 2018
commit a2db0896fbb7d40111bf49a7603cdbb12cede684
3 changes: 2 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ addons:
artifacts:
paths:
- $(ls powershell*{deb,pkg,AppImage,gz} | tr "\n" ":")
- pester-tests.xml
- ./tools/TestResultsSudo.xml
- ./tools/TestResultsNoSudo.xml

install:
# Default 2.0.0 Ruby is buggy
Expand Down
11 changes: 8 additions & 3 deletions tools/travis.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,16 @@ elseif($Stage -eq 'Build')
$ProgressPreference = $originalProgressPreference
}

$testResultsNoSudo = "$pwd\TestResultsNoSudo.xml"
$testResultsSudo = "$pwd\TestResultsSudo.xml"

$pesterParam = @{
'binDir' = $output
'PassThru' = $true
'Terse' = $true
'Tag' = @()
'ExcludeTag' = @('RequireSudoOnUnix')
Copy link
Member

@TravisEz13 TravisEz13 Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to specify two different values for '-OutputFile' and update https://github.com/PowerShell/PowerShell/blob/master/.travis.yml#L19 to upload both files

Copy link
Contributor Author

@kalgiz kalgiz Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to store the test results in output files as in ./tools/appveyor.psm1? Currently they are stored in variables ($pesterPassThruNoSudoObject, $pesterPassThruNSudoObject) and there was no -OutputFile specified for Start-PSPester cmdlet in travis.ps1

Copy link
Member

@TravisEz13 TravisEz13 Feb 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OutputFile has a default. travis.yml is assuming the default

'OutputFile' = $testResultsNoSudo
}

if ($isFullBuild) {
Expand All @@ -228,18 +232,19 @@ elseif($Stage -eq 'Build')
}

# Running tests which do not require sudo.
$pesterPassThruNoSudoObject = Start-PSPester @pesterParam
Start-PSPester @pesterParam

# Running tests, which require sudo.
pesterParam['Tag'] = @('RequireSudoOnUnix')
pesterParam['ExcludeTag'] = @()
pesterParam['Sudo'] = $true
$pesterPassThruSudoObject = Start-PSPester @pesterParam
pesterParam['OutputFile'] = $testResultsSudo
Start-PSPester @pesterParam

# Determine whether the build passed
try {
# this throws if there was an error
@($pesterPassThruNoSudoObject, $pesterPassThruSudoObject) | ForEach-Object { Test-PSPesterResults -ResultObject $_ }
@($testResultsNoSudo, $testResultsSudo) | ForEach-Object { Test-PSPesterResults -TestResultsFile $_ }
Copy link
Member

@TravisEz13 TravisEz13 Feb 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't change to the files, use the result objects. The files can cause be partial, and cause bugs.

Copy link
Contributor Author

@kalgiz kalgiz Feb 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I should just keep the code as it was before with pesterPassThru objects, but just add the output files?

$result = "PASS"
}
catch {
Expand Down