Get the VisualStudio solution working#6546
Merged
TravisEz13 merged 9 commits intoPowerShell:masterfrom Apr 3, 2018
Merged
Conversation
This reverts commit 9cbf601.
daxian-dbw
reviewed
Apr 3, 2018
PowerShell-Win.sln
Outdated
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.WSMan.Runtime", "src\Microsoft.WSMan.Runtime\Microsoft.WSMan.Runtime.csproj", "{D9CCCB67-4EBE-4854-AB52-C0129DC5BAE4}" | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.WSMan.Runtime", "src\Microsoft.WSMan.Runtime\Microsoft.WSMan.Runtime.csproj", "{D9CCCB67-4EBE-4854-AB52-C0129DC5BAE4}" | ||
| EndProject | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "powershell-unix", "src\powershell-unix\powershell-unix.csproj", "{73EA0BE6-C0C5-4B56-A5AA-DADA4C01D690}" |
Member
There was a problem hiding this comment.
Want to change this one as well?
| {8359D422-E0C4-4A0D-94EB-3C9DD16B7932}.Linux|Any CPU.ActiveCfg = Linux|Any CPU | ||
| {8359D422-E0C4-4A0D-94EB-3C9DD16B7932}.Linux|Any CPU.Build.0 = Linux|Any CPU | ||
| {8359D422-E0C4-4A0D-94EB-3C9DD16B7932}.Linux|Any CPU.ActiveCfg = Release|Any CPU | ||
| {8359D422-E0C4-4A0D-94EB-3C9DD16B7932}.Linux|Any CPU.Build.0 = Release|Any CPU |
Member
There was a problem hiding this comment.
This GUID points to powershell-win-core, so maybe Linux|Any is not needed.
Member
Author
There was a problem hiding this comment.
The whole solution has to support Linux... so I have to map it to a valid configuration for this project
| {D9CCCB67-4EBE-4854-AB52-C0129DC5BAE4}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {D9CCCB67-4EBE-4854-AB52-C0129DC5BAE4}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| {73EA0BE6-C0C5-4B56-A5AA-DADA4C01D690}.Linux|Any CPU.ActiveCfg = Linux|Any CPU | ||
| {73EA0BE6-C0C5-4B56-A5AA-DADA4C01D690}.Linux|Any CPU.Build.0 = Linux|Any CPU |
Member
There was a problem hiding this comment.
Linux|Any CPU
Should this be changed to Release|Any CPU?
| @@ -124,10 +124,6 @@ | |||
| {1} is a placeholder for a server name. Example: "localhost".</comment> | |||
| </data> | |||
| <assembly alias="System.Windows.Forms" name="System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" /> | |||
Member
There was a problem hiding this comment.
I thought this file can be removed, not?
Member
Author
There was a problem hiding this comment.
no, it's used and a different resource.
daxian-dbw
reviewed
Apr 3, 2018
| @@ -3,31 +3,33 @@ Microsoft Visual Studio Solution File, Format Version 12.00 | |||
| # Visual Studio 15 | |||
Member
There was a problem hiding this comment.
Can we have a comment here pointing to https://github.com/dotnet/project-system/blob/master/docs/opening-with-new-project-system.md#project-type-guids ?
daxian-dbw
approved these changes
Apr 3, 2018
adityapatwardhan
approved these changes
Apr 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Forking from #5209
TargetFrameworknot required tobuild in Visual Studio for Windows (works on Mac without the change.)
powershell-unixproject so you can choose which one to build.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests