Fix New-TemporaryFile online help URI#6608
Conversation
529d658 to
b7ca4d7
Compare
| /// The implementation of the "New-TemporaryFile" cmdlet | ||
| /// </summary> | ||
| [Cmdlet(VerbsCommon.New, "TemporaryFile", SupportsShouldProcess = true, HelpUri = "https://go.microsoft.com/fwlink/?LinkId=526726")] | ||
| [Cmdlet(VerbsCommon.New, "TemporaryFile", SupportsShouldProcess = true, HelpUri = "https://go.microsoft.com/fwlink/?LinkId=821836")] |
There was a problem hiding this comment.
This like resolves to PowerShell 5.1 (https://docs.microsoft.com/en-us/powershell/module/Microsoft.PowerShell.Utility/New-TemporaryFile?view=powershell-5.1) There is a PowerShell 6 page for this cmdlet (https://docs.microsoft.com/en-us/powershell/module/Microsoft.PowerShell.Utility/New-TemporaryFile?view=powershell-6)
There was a problem hiding this comment.
For most of our cmdlets we default to 5.1. @joeyaiello Are we going to change the default to 6?
There was a problem hiding this comment.
So the new fwlink points to 5.1, and IMO it should probably point to the version-agnostic link (for which we can change the default later). This way, when we update to 6, we can rev the default for all modules on docs.microsoft.com to 6.1, and then we don't have to change the fwlinks.
However, if we go that route, we need to make sure that 6 has distinct fwlinks from 5.1, and i'm not sure we've got that work fully understood or costed (that's a lot of fwlinks).
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days. |
|
@dantraMSFT The link now forwards to v6. Can you have another look? |
|
Is the PR ready to merge? |
|
@TravisEz13 Ready for Merge. |
|
@TravisEz13 ok to merge? |
Fixes #6186
PR Summary
Fix the link for online help content for New-TemporaryFile.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests