Fix Select-Object.Tests.ps1 which might fail for Unix OS.#6747
Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom Apr 30, 2018
Merged
Fix Select-Object.Tests.ps1 which might fail for Unix OS.#6747TravisEz13 merged 2 commits intoPowerShell:masterfrom
TravisEz13 merged 2 commits intoPowerShell:masterfrom
Conversation
…since idle process doesn't have a name specified on Unix.
TravisEz13
reviewed
Apr 26, 2018
|
|
||
| It "Select-Object with Start-Time In Idle Process should work"{ | ||
| It "Select-Object with Start-Time In Idle Process should work" -Skip:(!$IsWindows) { | ||
| $results = Get-Process i* | Select-Object ProcessName |
Member
There was a problem hiding this comment.
Why not just change it to Get-Process * removing the i from i* ?
TravisEz13
approved these changes
Apr 27, 2018
Collaborator
Has Unix |
Member
|
not in docker |
Member
|
@kalgiz can you update the title and summary for the current change? |
Collaborator
|
Then can we replace |
Contributor
Author
|
@TravisEz13 I updated the description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix Select-Object.Tests.ps1 which might fail for Unix OS.
In the test the processes which name matches i* are selected and it checks if there is non zero number of these processes. The test assumes that there is always at least one process - idle, but on Unix idle process does not have the name and hence the test might fail
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests