Update test-isfile to correct response for "/"#6754
Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom May 3, 2018
Patochun:patch-1
Merged
Update test-isfile to correct response for "/"#6754TravisEz13 merged 1 commit intoPowerShell:masterfrom Patochun:patch-1
TravisEz13 merged 1 commit intoPowerShell:masterfrom
Patochun:patch-1
Conversation
I Think the good answer for "/" is a directory, not a file. So I recommand to change EXPECT_TRUE by EXPECT_FALSE for this case.
Collaborator
|
@daxian-dbw @TravisEz13 Do you understand the PR? |
Member
|
@dantraMSFT Can you review? |
dantraMSFT
approved these changes
May 2, 2018
Contributor
Author
|
The change does not concern the error provided by Travis |
Collaborator
|
I restarted CI Travis Linux - Update-Help test temporary failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I Think the good answer for "/" is a directory, not a file.
PR Summary
I recommand to change EXPECT_TRUE by EXPECT_FALSE for the case test "/".
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests