Codestin Search App

rjmholt · 2018-04-28T19:21:18Z

PR Summary

Ubuntu 17.04 is EOL, so we need to update our packaging for Ubuntu 17.10. This updates the package script and build.psm1 to use 17.10 rather than 17.04.

The other things we should change to fully migrate are:

The dpkg URL and name
The README's Get PowerShell instructions
The Ubuntu 17.04 installation instructions
The Docker Ubuntu 17.10 template

Also, Fedora 25 is now EOL and we should move to 27. This should already be handled, but we need to test on in a Fedora 27 environment.

PR Checklist

iSazonov · 2018-04-29T12:22:43Z

I found 58 results by "Ubuntu" string in *.ps* files - I see there's something we need to fix, too.

TravisEz13 · 2018-04-30T19:18:00Z

@rjmholt Can you add a commit with [Package] at the beginning of the title? This will trigger package building.

I found 58 results by "Ubuntu" string in .ps files - I see there's something we need to fix, too.

I only found one line that needs to be changed. The docs should be moved to PowerShell/PowerShell-Docs

PowerShell/build.psm1

Line 137 in e9b045e

    
           $environment += @{'IsUbuntu17' = $Environment.IsUbuntu -and $LinuxInfo.VERSION_ID -match '17.04'}

rjmholt · 2018-05-02T22:42:01Z

Installing PowerShell on Fedora 28 I notice two things so far:

The installation manager GUI window you get when you double click on the RPM to install the PowerShell binary says the license is "proprietary" rather than "MIT".
I run into FailFast: The terminfo database is invalid #6132.

iSazonov · 2018-05-03T04:44:42Z

I think we should rebase to move to .Net Core 2.1 and then check that #6132 was fixed.

rjmholt · 2018-05-03T22:36:51Z

Okay I've run successfully installed PowerShell from master and run Start-PSPester -Tag "CI","Feature","RequireSudoOnLinux" under sudo on the following platforms:

	Ubuntu 17.10	Ubuntu 18.04	Fedora 27	Fedora 28
Succeeded	6226	6227	6226	6232
Failed	12	11	9	8
Skipped	1225	1225	1227	1227
Pending	419	419	419	419
Inconclusive	0	0	0	0
Total	7882	7882	7881	7886
Pester XML	pester-tests-ubuntu17.10.xml.zip	pester-tests-ubuntu18.04.xml.zip	pester-tests-fed27.xml.zip	pester-tests-fed28.xml.zip

Some of the problems I found:

On Fedora 28:
- PowerShell/test/powershell/engine/Remoting/SSHRemotingAPI.Tests.ps1
  
  Line 18 in 090f876
  
  It "SSHConnectionInfo constructor should throw null argument exception for null HostName parameter" {
  
  fails with the message Cannot process argument transformation on parameter 'Skip'. Cannot convert value "System.Object[]" to type "System.Management.Automation.SwitchParameter". Boolean parameters accept only Boolean values and numbers, such as $True, $False, 1 or 0. (line 27, char 102).
- PowerShell/test/powershell/Modules/Microsoft.PowerShell.Management/Get-Process.Tests.ps1
  
  Line 4 in f0b6ef2
  
  It "Should support -IncludeUserName" {
  
  fails with message Expected regular expression {fedora} to match {root}, but it did not match. (line 5) (fedora is the user on the VM).
- PowerShell/test/powershell/Modules/Microsoft.PowerShell.Management/New-Item.Tests.ps1
  
  Line 182 in 9ca059d
  
  It "Should error correctly when failing to create a symbolic link" -Skip:($IsWindows -or $IsElevated) {
  
  fails with message Expected an exception, with FullyQualifiedErrorId 'NewItemSymbolicLinkElevationRequired,Microsoft.PowerShell.Commands.NewItemCommand' to be thrown, but no exception was thrown. (line 185).
- PowerShell/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1
  
  Line 81 in 24cf020
  
  It "Force IPv4 with implicit PingOptions" {
  
  fails with message Expected exactly {2001:4860:4860::8888}, but got {8.8.8.8}. (line 84)
- PowerShell/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1
  
  Line 93 in 24cf020
  
  It "Force IPv4 with explicit PingOptions" {
  
  fails with message Expected exactly {2001:4860:4860::8888}, but got {8.8.8.8}. (line 98)
- PowerShell/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1
  
  Line 185 in 84344cb
  
  It "Continues works" {
  
  fails with message Expected {0}, but got {32}. (line 195)
- PowerShell/test/powershell/Modules/Microsoft.PowerShell.Utility/Export-Alias.Tests.ps1
  
  Line 97 in cc3ffd8
  
  It "Export-Alias for Force ReadOnly Test" {
  
  fails with message Expected an exception, with FullyQualifiedErrorId 'FileOpenFailure,Microsoft.PowerShell.Commands.ExportAliasCommand' to be thrown, but no exception was thrown. (line 108)
- PowerShell/test/powershell/Modules/Microsoft.PowerShell.Utility/Set-Date.Tests.ps1
  
  Line 15 in cc3ffd8
  
  Describe "Set-Date" -Tag 'CI' {
  
  fails with message Expected string to be the same, but they were different. ... Expected {System.ComponentModel.Win32Exception,Microsoft.PowerShell.Commands.SetDateCommand}, But Was: {No Exception!} (line 77)'
On Fedora 27, all the failures experienced in 28, plus a BeforeAll block:

PowerShell/test/powershell/engine/ParameterBinding/ParameterBinding.Tests.ps1

Line 374 in 1b3c8ac

Add-Type -OutputAssembly $dllPath -TypeDefinition '

fails with The file '/tmp/TestBindingCmdlet.dll' already exists. (line 374, char 13).
On Ubuntu 18.04, all the tests failing on Fedora 27 fail, plus:
- a native command processor test seems to call less, which halts the test execution. This test:
  
  PowerShell/test/powershell/Language/Scripting/NativeExecution/NativeCommandProcessor.Tests.ps1
  
  Line 133 in ceef2e3
  
  Describe "Open a text file with NativeCommandProcessor" -tags @("Feature", "RequireAdminOnWindows") {
- The above test also fails with message Expected exactly {/tmp/f581d4d2-b000-43d7-8960-0c9de6081b30/TextFileTest.txt}, but got {}. (line 210)
- PowerShell/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1
  
  Line 31 in 24cf020
  
  It "Default parameter set is 'Ping'" {
  
  fails with message Expected {0}, but got {32}. (line 46).
- PowerShell/test/powershell/Modules/Microsoft.PowerShell.Utility/Invoke-Item.Tests.ps1
  
  Line 124 in cc3ffd8
  
  It "Should invoke a folder without error" -Skip:(!$supportedEnvironment) {
  
  fails with message Expected {/home/ubuntu/PowerShell/src/powershell-unix/bin/Linux/netcoreapp2.1/linux-x64/publish}, but got {}. (line 148).
On Ubuntu 17.10, all tests failing on Ubuntu18.04 fail, plus:
- PowerShell/test/powershell/Modules/Microsoft.PowerShell.Management/Test-Connection.Tests.ps1
  
  Line 150 in 24cf020
  
  It "BufferSize works" {
  
  fails with message Expected {0}, but got {2}. (line 154)

rjmholt · 2018-05-03T22:42:00Z

I built a .deb the other day for Ubuntu 17.10, but it didn't work. Trying again today.

rjmholt · 2018-05-04T02:56:30Z

Have verified a working Ubuntu 17.10 package built with this branch.

(Can't attach due to size)

rjmholt · 2018-05-04T03:32:07Z

Also confirm that the produced Ubuntu 18.04 package works!

iSazonov · 2018-05-04T08:17:50Z

tools/packaging/packaging.psm1

                "ubuntu.14.04" { $Dependencies += @("libssl1.0.0", "libicu52") }
                "ubuntu.16.04" { $Dependencies += @("libssl1.0.0", "libicu55") }
                "ubuntu.17.10" { $Dependencies += @("libssl1.0.0", "libicu57") }
+                "ubuntu.18.04" { $Dependencies += @("libssl1.0.0", "libssl1.1", "libicu60") }


Do we really need both libssl?

iSazonov · 2018-05-04T08:22:22Z

As for Test-Connection tests I think it is mostly from .Net Core. I have no way to check on other Linux-s.

iSazonov · 2018-05-04T09:23:21Z

Fedora 27 related PR #6819.

TravisEz13 · 2018-05-04T17:12:27Z

tools/packaging/packaging.psm1

                "ubuntu.16.04" { $Dependencies += @("libssl1.0.0", "libicu55") }
-                "ubuntu.17.04" { $Dependencies += @("libssl1.0.0", "libicu57") }
+                "ubuntu.17.10" { $Dependencies += @("libssl1.0.0", "libicu57") }
+                "ubuntu.18.04" { $Dependencies += @("libssl1.0.0", "libssl1.1", "libicu60") }


I think @iSazonov is correct. We only need libssl1.0.0

TravisEz13 · 2018-05-07T19:32:07Z

@anmenaga FYI this will change the package name for ubuntu 17.10

anmenaga · 2018-05-07T19:35:11Z

@TravisEz13 good point, thx. I'll prepare PR to fix dockerfile; and looks like we need to add dockerfiles for new '18.04' config.

kenk667 · 2018-05-16T05:44:37Z

@rjmholt I may have an interim solution for installing on 18.04 without downgrading curl or libicu, I was able to successfully install on 18.04 by changing the dependencies for https://github.com/PowerShell/PowerShell/releases/download/v6.1.0-preview.2/powershell_6.1.0-preview.2-1.ubuntu.17.04_amd64.deb

dpkg-deb --raw-exatrct powershell_6.1.0-preview.2-1.ubuntu.17.04_amd64.deb 6.1.0_patched

Then alter two patterns, curl and libicu dependencies to current versions;

sudo awk '{gsub("curl3","curl4");gsub("libicu57","libicu60");print}' 6.1.0_pathched/DEBIAN/control

Repackage as a debian package;

dpkg-deb --build 6.1.0_pathched/ powershell_6.1.0-patched.2-1.ubuntu.18.04_amd64.deb

Now just install the newly patched .deb package, I like to use gdebi to install;

sudo gdebi powershell_6.1.0-patched.2-1.ubuntu.18.04_amd64.deb

I haven't extensively tested this but seems to be functional and stable so far

TravisEz13 · 2018-05-17T21:56:19Z

@kenk667 The required libraries are determined by DotNet Core. Changing the required libraries could leave you unsupported.

Change packaging to use ubuntu 17.10

b6e1e4a

rjmholt requested review from JamesWTruher, TravisEz13 and daxian-dbw April 28, 2018 19:21

rjmholt requested a review from adityapatwardhan as a code owner April 28, 2018 19:21

iSazonov assigned TravisEz13 Apr 29, 2018

[package]Change packaging to use ubuntu 17.10

5c01416

rjmholt force-pushed the update-ubuntu17.10-build branch from b6e1e4a to 5c01416 Compare April 30, 2018 21:58

rjmholt changed the title ~~Change packaging to use ubuntu 17.10~~ WIP: Change packaging to use ubuntu 17.10 May 2, 2018

[package] Add Ubuntu 18.04 packaging

db04f73

rjmholt unassigned TravisEz13 May 4, 2018

rjmholt changed the title ~~WIP: Change packaging to use ubuntu 17.10~~ Change packaging to support Ubuntu 17.10 and 18.04 May 4, 2018

[Package] Add Ubuntu 18.04 build support

62c93ed

rjmholt force-pushed the update-ubuntu17.10-build branch from 2dfe54a to 62c93ed Compare May 4, 2018 03:33

iSazonov reviewed May 4, 2018

View reviewed changes

TravisEz13 reviewed May 4, 2018

View reviewed changes

[Package] Remove libssl1.1 requirement

e5a7c6d

TravisEz13 approved these changes May 7, 2018

View reviewed changes

TravisEz13 added the WG-Maintainers-Build specific to affecting the build label May 7, 2018

TravisEz13 mentioned this pull request May 7, 2018

PowerShell 6.0 docs should be updates for Fedora and Ubuntu EOLs MicrosoftDocs/PowerShell-Docs#2302

Closed

8 tasks

TravisEz13 merged commit d96a321 into PowerShell:master May 7, 2018

iSazonov mentioned this pull request May 10, 2018

Support Ubuntu 18.04 #6692

Closed

rjmholt deleted the update-ubuntu17.10-build branch June 22, 2018 22:55

Conversation

rjmholt commented Apr 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

iSazonov commented Apr 29, 2018

Uh oh!

TravisEz13 commented Apr 30, 2018

Uh oh!

rjmholt commented May 2, 2018

Uh oh!

iSazonov commented May 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rjmholt commented May 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rjmholt commented May 3, 2018

Uh oh!

rjmholt commented May 4, 2018

Uh oh!

rjmholt commented May 4, 2018

Uh oh!

iSazonov May 4, 2018

Choose a reason for hiding this comment

Uh oh!

iSazonov commented May 4, 2018

Uh oh!

iSazonov commented May 4, 2018

Uh oh!

TravisEz13 May 4, 2018

Choose a reason for hiding this comment

Uh oh!

TravisEz13 commented May 7, 2018

Uh oh!

anmenaga commented May 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kenk667 commented May 16, 2018

Uh oh!

TravisEz13 commented May 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rjmholt commented Apr 28, 2018 •

edited

Loading

iSazonov commented May 3, 2018 •

edited

Loading

rjmholt commented May 3, 2018 •

edited

Loading

anmenaga commented May 7, 2018 •

edited

Loading