Disallow Basic Auth over HTTP on Unix#6787
Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom May 2, 2018
dantraMSFT:dantra/issue6779
Merged
Disallow Basic Auth over HTTP on Unix#6787TravisEz13 merged 2 commits intoPowerShell:masterfrom dantraMSFT:dantra/issue6779
TravisEz13 merged 2 commits intoPowerShell:masterfrom
dantraMSFT:dantra/issue6779
Conversation
markekraus
suggested changes
May 1, 2018
| <value>{0} authentication requires an explicit user name and password. Specify the user name and password by using the -Credential parameter and try the command again.</value> | ||
| </data> | ||
| <data name="BasicAuthOverHttpNotSupported"> | ||
| <value>Basic authentication is not supported over HTTP on Unix</value> |
iSazonov
reviewed
May 2, 2018
| } | ||
| catch | ||
| { | ||
| $_.Exception | Should -BeOfType [System.Management.Automation.Remoting.PSRemotingTransportException] |
Collaborator
There was a problem hiding this comment.
We should use
$ex = { ... } | Should -Throw -PassThrou "FullyQualifiedErrorId"
$ex.Exception ...
Member
There was a problem hiding this comment.
iSazonov
approved these changes
May 2, 2018
markekraus
approved these changes
May 2, 2018
Member
|
This is a user-facing change. Please file a doc issue in PowerShell-Docs |
8 tasks
Contributor
Author
|
Doc issue file: MicrosoftDocs/PowerShell-Docs#2394 |
TravisEz13
approved these changes
May 2, 2018
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Disallow Basic Auth over HTTP on Unix
Fix: #6779
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests