Codestin Search App

sethvs · 2018-05-02T08:24:22Z

PR Summary

Improve code coverage in Export-Csv.Tests.ps1.

PR Checklist

markekraus · 2018-05-02T08:33:04Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Export-Csv.Tests.ps1

-    BeforeAll {
-        $filePath = Join-Path $TestDrive -ChildPath "test.csv"
-        $newLine = [environment]::NewLine
+    It "Should be able to use -LiteralPath parameter" {


Should be able to use -> Should support

markekraus · 2018-05-02T08:36:38Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Export-Csv.Tests.ps1

+        $results = Import-Csv -Path $testCsv
+
+        $results.P2 | Should -BeExactly "second"
+        $property = $results | Get-Member | Where-Object { $_.MemberType -eq "NoteProperty" } | ForEach-Object { $_.Name }


perhaps:

$property = $results.PSObject.Properties.Name

markekraus · 2018-05-02T08:37:18Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Export-Csv.Tests.ps1

+        $results = Import-Csv -Path $testCsv
+
+        $results.P1 | Should -BeExactly "first"
+        $property = $results | Get-Member | Where-Object { $_.MemberType -eq "NoteProperty" } | ForEach-Object { $_.Name }


same as above.

markekraus · 2018-05-02T08:37:37Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Export-Csv.Tests.ps1

+        $results = Import-Csv -Path $testCsv
+
+        $results.P1 | Should -BeExactly "first"
+        $property = $results | Get-Member | Where-Object { $_.MemberType -eq "NoteProperty" } | ForEach-Object { $_.Name }


same as above

markekraus · 2018-05-02T08:38:19Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Export-Csv.Tests.ps1

+        $results = Import-Csv -Path $testCsv
+
+        $results.P2 | Should -BeExactly "second"
+        $property = $results | Get-Member | Where-Object { $_.MemberType -eq "NoteProperty" } | ForEach-Object { $_.Name }


same as above

markekraus · 2018-05-02T08:41:55Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Export-Csv.Tests.ps1

+
+        $results.P1 | Should -BeExactly "first"
+        $property = $results | Get-Member | Where-Object { $_.MemberType -eq "NoteProperty" } | ForEach-Object { $_.Name }
+        $property | Should -BeExactly P1


P1 should be quoted

markekraus · 2018-05-02T08:42:03Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Export-Csv.Tests.ps1

+
+        $results.P2 | Should -BeExactly "second"
+        $property = $results | Get-Member | Where-Object { $_.MemberType -eq "NoteProperty" } | ForEach-Object { $_.Name }
+        $property | Should -BeExactly P2


P2 should be quoted

markekraus · 2018-05-02T08:42:18Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Export-Csv.Tests.ps1

+        $results[0].P1 | Should -BeExactly "first"
+        $results[1].P1 | Should -BeExactly "eleventh"
+        $property = $results | Get-Member | Where-Object { $_.MemberType -eq "NoteProperty" } | ForEach-Object { $_.Name }
+        $property | Should -BeExactly P1


P1 should be quoted

markekraus · 2018-05-02T08:42:36Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Export-Csv.Tests.ps1

+
+        $results[0].P1 | Should -BeExactly "eleventh"
+        $property = $results | Get-Member | Where-Object { $_.MemberType -eq "NoteProperty" } | ForEach-Object { $_.Name }
+        $property | Should -BeExactly P1


P1 should be quoted

markekraus · 2018-05-02T08:42:56Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Export-Csv.Tests.ps1

+
+        $results[0].P1 | Should -BeExactly "first"
+        $property = $results | Get-Member | Where-Object { $_.MemberType -eq "NoteProperty" } | ForEach-Object { $_.Name }
+        $property | Should -BeExactly P1


P1 should be quoted

sethvs · 2018-05-02T09:28:30Z

Fixed.

iSazonov · 2018-05-02T13:21:58Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Export-Csv.Tests.ps1

+
+        $results.P2 | Should -BeExactly "second"
+        $property = $results.PSObject.Properties.Name
+        $property | Should -BeExactly "P2"


Seems it is a duplicate line 91 and should be removed- the line failed if we haven't "P2" property and we never reach line 93. Below too.

Maybe better remove 92 and 93, since line 91 covers both property name and value?

iSazonov · 2018-05-02T13:25:33Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Export-Csv.Tests.ps1

+        $property | Should -BeExactly "P1"
+    }
+
+    It "Should append to empty file if -Append parameter specified" {


I believe we should remove the tests - it repeats the previous test.

There is a branch in code that this test covers.

Please add the comment that it does not duplicate the previous test and checks another branch of the code.

iSazonov · 2018-05-02T13:33:55Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Export-Csv.Tests.ps1

+
        $contents.Count | Should -Be 2
        $contents[0].Contains($delimiter) | Should -BeTrue
        $contents[1].Contains($delimiter) | Should -BeTrue


We could use Should -Contain

No. If the delimiter is comma, Should treats input as array, so $contents[0] | Should -Contain $delimiter will fail.

$contents[0] is a string not a language operator.
I think it is passed:
"," | Should -Contain ","

It "Test export-csv with a useculture flag" { $outputFilesDir = Join-Path -Path $TestDrive -ChildPath "Monad" $fileToGenerate = Join-Path -Path $outputFilesDir -ChildPath "CSVTests.csv" $delimiter = (Get-Culture).TextInfo.ListSeparator New-Item -Path $outputFilesDir -ItemType Directory -Force Get-Item -Path $outputFilesDir | Export-Csv -Path $fileToGenerate -UseCulture -NoTypeInformation $contents = Get-Content -Path $fileToGenerate $contents.Count | Should -Be 2 $contents[0] | Should -Contain $delimiter } [-] Test export-csv with a useculture flag 144ms Expected ',' to be found in collection "PSPath","PSParentPath","PSChildName","PSDrive","PSProvider","PSIsContainer","Mode","BaseName","Target","LinkType","Name","Parent","Exists","Root","FullName","Extension","CreationTime","CreationTimeUtc","LastAccessTime","LastAccessTimeUtc","LastWriteTime","LastWriteTimeUtc","Attributes", but it was not found. 186: $contents[0] | Should -Contain $delimiter

Thanks for the repo! This is my misconception. Closed.

adityapatwardhan · 2018-05-02T21:37:15Z

test/powershell/Modules/Microsoft.PowerShell.Utility/Export-Csv.Tests.ps1

+
+    # This test is not a duplicate of previous one, since it covers a separate branch in code.
+    It "Should append to empty file if -Append parameter specified" {
+        New-Item -Path $testCsv -ItemType File


New-Item … > $null

adityapatwardhan · 2018-05-04T16:46:46Z

@sethvs Thanks for your contribution!

Improve code coverage in Export-Csv.Tests.ps1.

4894367

markekraus suggested changes May 2, 2018

View reviewed changes

Implement requested changes.

64defc5

iSazonov reviewed May 2, 2018

View reviewed changes

Implement requested changes 2.

5d58382

iSazonov approved these changes May 2, 2018

View reviewed changes

iSazonov assigned adityapatwardhan May 2, 2018

markekraus approved these changes May 2, 2018

View reviewed changes

adityapatwardhan requested changes May 2, 2018

View reviewed changes

Add Out-Null.

62ea92d

sethvs changed the title ~~Improve code coverage in Export-Csv.Tests.ps1.~~ WIP: Improve code coverage in Export-Csv.Tests.ps1. May 3, 2018

Add tests covering ExportCsvHelper.

b5555a3

sethvs changed the title ~~WIP: Improve code coverage in Export-Csv.Tests.ps1.~~ Improve code coverage in Export-Csv.Tests.ps1. May 3, 2018

Change test logic.

b2b2692

adityapatwardhan approved these changes May 4, 2018

View reviewed changes

adityapatwardhan merged commit 1be0594 into PowerShell:master May 4, 2018

sethvs deleted the ExportCsvTests branch May 21, 2018 16:25

Conversation

sethvs commented May 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sethvs commented May 2, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iSazonov May 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adityapatwardhan commented May 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sethvs commented May 2, 2018 •

edited

Loading

iSazonov May 2, 2018 •

edited

Loading