Add functions into build.psm1 to Save and Restore PSOptions between different sessions.#6884
Merged
TravisEz13 merged 8 commits intoPowerShell:masterfrom May 18, 2018
Merged
Conversation
…ifferent sessions.
iSazonov
reviewed
May 17, 2018
build.psm1
Outdated
| } | ||
| } | ||
|
|
||
| $psOptionsPath = 'psoptions.json' |
Collaborator
There was a problem hiding this comment.
Should we exclude the file from git?
Member
There was a problem hiding this comment.
We will only use this during CI workflow currently. We can ignore it if it becomes a problem.
TravisEz13
reviewed
May 17, 2018
build.psm1
Outdated
| $psOptionsPath = 'psoptions.json' | ||
|
|
||
| function Save-PSOptions { | ||
| $Script:Options = Get-PSOptions |
Member
There was a problem hiding this comment.
no need to use the script scop in a variable used entirely inside a function
TravisEz13
requested changes
May 17, 2018
Member
TravisEz13
left a comment
There was a problem hiding this comment.
please address scope comment
TravisEz13
approved these changes
May 18, 2018
f2e499b to
9809100
Compare
Member
|
I've triggered an official build off this branch to verify my changes don't break the official build. |
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Aug 18, 2018
…ifferent sessions. (PowerShell#6884)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add functions into build.psm1 to Save and Restore PSOptions between different sessions.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests