Cleanup FileSystem provider#6909
Merged
iSazonov merged 5 commits intoPowerShell:masterfrom Jun 4, 2018
Merged
Conversation
IO.FileInfo does not make system calls in constructor. So we can create the object and then use the required attributes.
d850ef5 to
ebe19a5
Compare
4b1fe47 to
ef7430c
Compare
adityapatwardhan
approved these changes
May 23, 2018
Collaborator
Author
|
@SteveL-MSFT @daxian-dbw Could you please look the PR? |
SteveL-MSFT
approved these changes
May 31, 2018
Collaborator
Author
|
@daxian-dbw Seems the PR is ready to merge - could you please look? |
11 tasks
3 tasks
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Related #6874. The PR is coming from a code review to cleanup psl. Here we clean up the side branch of the code that will allow later to clean up a branch which uses psl.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests