Fix broken links due to PR 6899 that removed GitHub docs on installation docs, known issues and breaking changes due to complete migration to docs.microsoft.com#6981
Merged
adityapatwardhan merged 5 commits intoPowerShell:masterfrom Jun 6, 2018
Conversation
11 tasks
11 tasks
TravisEz13
approved these changes
Jun 4, 2018
adityapatwardhan
requested changes
Jun 5, 2018
.github/ISSUE_TEMPLATE.md
Outdated
| - Search the existing issues. | ||
| - Refer to the [FAQ](https://github.com/PowerShell/PowerShell/blob/master/docs/FAQ.md). | ||
| - Refer to the [known issues](https://github.com/PowerShell/PowerShell/blob/master/docs/KNOWNISSUES.md). | ||
| - Refer to the [known issues](https://docs.microsoft.com/en-us/powershell/scripting/whats-new/known-issues-ps6?view=powershell-6). |
Member
There was a problem hiding this comment.
Maybe we should drop the en-us part from the url. So it will redirect to appropriate language according to locale. @sdwheeler am I correct?
README.md
Outdated
| [in-archlinux]: https://github.com/PowerShell/PowerShell/tree/master/docs/installation/linux.md#arch-linux | ||
| [in-appimage]: https://github.com/PowerShell/PowerShell/tree/master/docs/installation/linux.md#linux-appimage | ||
| [in-macos]: https://github.com/PowerShell/PowerShell/tree/master/docs/installation/macos.md | ||
| [in-windows]: https://docs.microsoft.com/en-us/powershell/scripting/setup/installing-powershell-core-on-windows?view=powershell-6 |
Member
There was a problem hiding this comment.
The above comment about en-us also applies to all urls here.
Contributor
Author
|
@adityapatwardhan I removed the en-us culture in the links |
adityapatwardhan
approved these changes
Jun 5, 2018
Collaborator
|
Assuming this PR looks good, it needs to be merged. Not cool having the install instructions links be broken for multiple days. Props to @bergmeister for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
To fix broken links due to PR #6899 and remove unnecessary spelling items
Fixes #6983
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests