Fix links to PowerShell on install docs#7001
Merged
iSazonov merged 2 commits intoPowerShell:masterfrom Jun 7, 2018
jokajak:patch-1
Merged
Fix links to PowerShell on install docs#7001iSazonov merged 2 commits intoPowerShell:masterfrom jokajak:patch-1
iSazonov merged 2 commits intoPowerShell:masterfrom
jokajak:patch-1
Conversation
Updated Install on macOS link per https://github.com/PowerShell/PowerShell/blob/master/docs/DOCSMIGRATION.md
Contributor
Author
|
I failed to use the present tense and imperative mood when generating the change in my browser. Is that cause to reject this small PR? |
daxian-dbw
reviewed
Jun 5, 2018
docs/learning-powershell/README.md
Outdated
| @@ -31,7 +31,7 @@ At the end of this exercise, you should be able to launch the PowerShell session | |||
|
|
|||
| [inst-linux]: ../installation/linux.md | |||
| [inst-win]: ../installation/windows.md | |||
Member
There was a problem hiding this comment.
Would you mind fixing the installation docs for Linux and Windows too? Thanks!
Contributor
There was a problem hiding this comment.
daxian-dbw
reviewed
Jun 5, 2018
docs/learning-powershell/README.md
Outdated
| [inst-linux]: ../installation/linux.md | ||
| [inst-win]: ../installation/windows.md | ||
| [inst-macos]: ../installation/macos.md | ||
| [inst-macos]: https://github.com/PowerShell/PowerShell-Docs/blob/staging/reference/docs-conceptual/setup/Installing-PowerShell-Core-on-macOS.md |
Member
There was a problem hiding this comment.
Please use https://docs.microsoft.com/en-us/powershell/scripting/setup/installing-powershell-core-on-macos?view=powershell-6 instead.
Contributor
There was a problem hiding this comment.
Please use https://docs.microsoft.com/powershell/scripting/setup/installing-powershell-core-on-macos?view=powershell-6 (i.e. without the en-us culture) instead, otherwise looks good.
Updates links to point to microsoft website instead of documents that have been removed
bergmeister
approved these changes
Jun 7, 2018
iSazonov
approved these changes
Jun 7, 2018
Collaborator
|
@jokajak Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Update Install doc links.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests