Codestin Search App

sethvs · 2018-06-09T15:17:56Z

PR Summary

Get-ChildItem c: throws an error. #7032

Get-ChildItem c:

Get-ChildItem : Cannot find path 'C:\C:\' because it does not exist.
At line:1 char:1
+ Get-ChildItem c:
+ ~~~~~~~~~~~~~~~~
+ CategoryInfo          : ObjectNotFound: (C:\C:\:String) [Get-ChildItem], ItemNotFoundException
+ FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.GetChildItemCommand

When creating file using -Path c: without a backslash, file created in the drive root and not in the current folder. #7048

Windows PowerShell 5.1: file is created in current path - C:\Folder

[5.1] PS C:\Folder> New-Item -Path c: -Name testfile.txt


    Directory: C:\Folder


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----        6/14/2018  12:30 PM              0 testfile.txt

PowerShell Core 6.0.2: file is created in current path - C:\Folder

[6.0.2] PS C:\Folder> New-Item -Path c: -Name testfile.txt


    Directory: C:\Folder


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----        6/14/2018  12:32 PM              0 testfile.txt

PowerShell Core 6.1.0-preview.2: file is created in current path - C:\Folder

[6.1.0-preview.2] PS C:\Folder> New-Item -Path c: -Name testfile.txt


    Directory: C:\Folder


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----        6/14/2018  12:28 PM              0 testfile.txt

PowerShell Core 6.1.0-preview.3: file is created in root path - C:\

[6.1.0-preview.3] PS C:\Folder> New-Item -Path c: -Name testfile.txt


    Directory: C:\


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----        6/14/2018  12:29 PM              0 testfile.txt

PR Checklist

bergmeister · 2018-06-10T09:10:12Z

@sethvs Please push an empty commit to trigger another build since there seemed to be a sporadic problem that caused the build to hang and timeout. You could do this for example as follows, I recommend putting [feature] in the message so that more advanced tests run as well to test your change, which would be useful for this PR.

git commit -m [feature] --allow-empty
git push

@iSazonov This happened to me last week as well that a build got into a hanging state. Have you see that before as well or is this probably caused by a recently added test?

iSazonov · 2018-06-10T18:42:06Z

@bergmeister Do you mean a problem only with CIs (not local)?
Can you open new Issue and provide links on broken CI jobs?

bergmeister · 2018-06-10T22:30:20Z

@iSazonov I mean the AppVeyor run of this PR here. It must have got stuck or in a hanging state because it timed out after 3 hours.
The same build happened to this PR build of PR 7013. It seems that it happens only randomly.
I put those details into the new issue #7038
To be able to still analyse this build failure later on, we should not restart this build ourselves but rather push a new commit for a new build.

anmenaga · 2018-06-12T19:19:51Z

@sethvs After fixing current test failures in New-Item.Tests.ps1, please do a [feature] commit as @bergmeister suggested. Those namespaces APIs is a very fragile piece of code; so we need to run as many tests as we can to ensure that nothing gets broken by these changes.

sethvs · 2018-06-13T08:15:17Z

@anmenaga OK.

sethvs · 2018-06-13T09:29:17Z

Update-Help and PowerShellGet tests fail.
Can we restart Travis CI?

iSazonov · 2018-06-13T10:59:29Z

@sethvs Please look #6149 - perhaps we could fix it too.

sethvs · 2018-06-13T11:03:32Z

@iSazonov OK, will take a look.

sethvs · 2018-06-14T10:05:38Z

@adityapatwardhan @iSazonov I'm afraid I can't allocate much time at the moment. So let's split fixing #6149 to another PR in order not to delay this one. I'm going to address it later.

sethvs · 2018-06-14T12:42:10Z

Empty commit to restart tests.

adityapatwardhan · 2018-06-14T17:47:09Z

@sethvs it seems that #7048 is fixed in preview.3

adityapatwardhan · 2018-06-14T17:47:43Z

@rjmholt Can you have a look too?

sethvs · 2018-06-15T07:45:41Z

@adityapatwardhan No, it is not fixed.
The description of this PR contains examples of the issue in 6.1.0-preview.3.

iSazonov

Leave a comment

rjmholt

Going to build this branch and have a look at it, but it looks good so far.

rjmholt · 2018-06-19T17:02:06Z

src/System.Management.Automation/engine/SessionStateContainer.cs

                {
                    PSTraceSource.NewArgumentNullException("paths");
                }
+                else if (path.EndsWith((":" + Path.DirectorySeparatorChar), StringComparison.Ordinal) || path.EndsWith((":" + Path.AltDirectorySeparatorChar), StringComparison.Ordinal))


Might be worth hanging a line for the second path check.

Agree, done.

rjmholt

Ok, I've put this branch through a test run and got no unusual failures. This looks good to me!

Fix error when using Get-ChildItem c:

5d5d5d6

sethvs requested review from BrucePay and anmenaga as code owners June 9, 2018 15:17

Fix New-Item test issue.

8d2e558

sethvs requested a review from daxian-dbw as a code owner June 12, 2018 15:04

sethvs added 2 commits June 12, 2018 18:28

Add tests for Get-ChildItem cmdlet.

ba2d50e

Add tests for New-Item cmdlet.

2d70fac

sethvs added 2 commits June 13, 2018 10:35

Fix tests for New-Item cmdlet.

2a7b4d4

Merge branch 'master' into GetChildItem

b4e0522

[Feature]

2f6b5a3

daxian-dbw assigned adityapatwardhan Jun 13, 2018

sethvs mentioned this pull request Jun 14, 2018

When creating file using -Path c: without a backslash, file created in the drive root and not in the current folder. #7048

Closed

[Feature]

1f6a8ca

adityapatwardhan requested a review from rjmholt June 14, 2018 17:47

iSazonov mentioned this pull request Jun 19, 2018

Revert change to have SetLocation() treat wildcarded path as literal if it exists #7101

Merged

11 tasks

iSazonov approved these changes Jun 19, 2018

View reviewed changes

rjmholt reviewed Jun 19, 2018

View reviewed changes

Move the second check to the separate line.

9b3417b

rjmholt approved these changes Jun 25, 2018

View reviewed changes

adityapatwardhan approved these changes Jun 25, 2018

View reviewed changes

adityapatwardhan merged commit ffca008 into PowerShell:master Jun 25, 2018

sethvs deleted the GetChildItem branch July 20, 2018 12:56

Conversation

sethvs commented Jun 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

bergmeister commented Jun 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iSazonov commented Jun 10, 2018

Uh oh!

bergmeister commented Jun 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anmenaga commented Jun 12, 2018

Uh oh!

sethvs commented Jun 13, 2018

Uh oh!

sethvs commented Jun 13, 2018

Uh oh!

iSazonov commented Jun 13, 2018

Uh oh!

sethvs commented Jun 13, 2018

Uh oh!

sethvs commented Jun 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sethvs commented Jun 14, 2018

Uh oh!

adityapatwardhan commented Jun 14, 2018

Uh oh!

adityapatwardhan commented Jun 14, 2018

Uh oh!

sethvs commented Jun 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iSazonov left a comment

Choose a reason for hiding this comment

Uh oh!

rjmholt left a comment

Choose a reason for hiding this comment

Uh oh!

rjmholt Jun 19, 2018

Choose a reason for hiding this comment

Uh oh!

sethvs Jun 20, 2018

Choose a reason for hiding this comment

Uh oh!

rjmholt left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sethvs commented Jun 9, 2018 •

edited

Loading

bergmeister commented Jun 10, 2018 •

edited

Loading

bergmeister commented Jun 10, 2018 •

edited

Loading

sethvs commented Jun 14, 2018 •

edited

Loading

sethvs commented Jun 15, 2018 •

edited

Loading