When installing using MSI, set the working directory of the shortcut to the user home directory#7072
Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom Jun 20, 2018
Merged
Conversation
b7a9809 to
aea37d5
Compare
TravisEz13
approved these changes
Jun 15, 2018
Member
|
Your commit isn't associated with your github id. Can you fix that? |
aea37d5 to
c47fe86
Compare
c47fe86 to
ef37d2c
Compare
bergmeister
approved these changes
Jun 15, 2018
Contributor
bergmeister
left a comment
There was a problem hiding this comment.
LGTM if you have tested it and it works.
iSazonov
reviewed
Jun 16, 2018
assets/Product.wxs
Outdated
| Target="[$(var.ProductDirectoryName)]pwsh.exe" | ||
| Target="[$(var.ProductDirectoryName)]pwsh.exe" | ||
| Arguments="-WorkingDirectory ~" | ||
| WorkingDirectory="$(var.ProductDirectoryName)" |
Collaborator
There was a problem hiding this comment.
Seems we can remove the line.
Member
|
I'd suggest addressing @iSazonov 's comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Leverage the
-WorkingDirectoryparameter on pwsh.exe to set the initial location.Fix #5705
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests