Disambiguate icon on Windows for preview builds/installers to use Powershell_av_colors and make daily build use Powershell_avatar instead#7086
Conversation
…ershell_av_colors and make daily build use Powershell_avatar instead
|
|
|
|
||
| Write-Verbose "Change icon to disambiguate it from a released installation" -Verbose | ||
| & "~/.rcedit/rcedit-x64.exe" "$Destination\pwsh.exe" --set-icon "$Destination\assets\Powershell_av_colors.ico" | ||
| & "~/.rcedit/rcedit-x64.exe" "$Destination\pwsh.exe" --set-icon "$Destination\assets\Powershell_avatar.ico" |
There was a problem hiding this comment.
why isn't this one of the same icons set during the build?
There was a problem hiding this comment.
This is for the daily build only (which I still want to disambiguate from preview as I have RTM, preview and daily versions pinned to my taskbar), see my summary.
|
@TravisEz13 The PR is now fully ready for review, I just had to test the |
PR Summary
Closes #6317
Using the preview side-by-side with the RTM version is a pain/confusing due to the icons being the same.
This makes the preview build (i.e. the embedded icon in
pwsh.exe) and MSI installer package (shortcut icon and context menu) use the Powershell_av_colors iconTherefore change the icon of the daily build (which used to use the Powershell_av_colors icon) to Powershell_avatar
This means that people like me who have a shortcut to pwsh of the daily build pinned to the taskbar, probably need to re-pin it to the taskbar to receive all changes (otherwise one will only get the change in the icon of the window)
Note: The
Test-IsPreviewmethod had to be moved to the build module, which is OK because the packaging module has a declared dependency on the build module in its manifest.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests