Remove MapSecurityZoneWithUrlmon method and related code#7103
Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom Jun 25, 2018
Merged
Remove MapSecurityZoneWithUrlmon method and related code#7103daxian-dbw merged 2 commits intoPowerShell:masterfrom
daxian-dbw merged 2 commits intoPowerShell:masterfrom
Conversation
anmenaga
suggested changes
Jun 18, 2018
anmenaga
left a comment
There was a problem hiding this comment.
Neither "PR Summary" nor original issue have a description why this change is necessary.
Member
TravisEz13
approved these changes
Jun 18, 2018
daxian-dbw
requested changes
Jun 18, 2018
| @@ -139,19 +139,11 @@ internal static SecurityZone GetFileSecurityZone(string filePath) | |||
| Diagnostics.Assert(Path.IsPathRooted(filePath), "Caller makes sure the path is rooted."); | |||
| Diagnostics.Assert(Utils.FileExists(filePath), "Caller makes sure the file exists."); | |||
| string sysRoot = System.Environment.GetEnvironmentVariable("SystemRoot"); | |||
Member
There was a problem hiding this comment.
This variable is not used anymore.
| @@ -448,60 +403,6 @@ private static class NativeMethods | |||
| internal static extern uint GetACP(); | |||
|
|
|||
| public const int S_OK = 0x00000000; | |||
Member
There was a problem hiding this comment.
Is this one still used anywhere?
| @@ -448,60 +403,6 @@ private static class NativeMethods | |||
| internal static extern uint GetACP(); | |||
Member
There was a problem hiding this comment.
This function doesn't seem to be used anymore.
anmenaga
approved these changes
Jun 18, 2018
|
@TravisEz13 "edited" after I posted the request. :) |
Member
|
@anmenaga I'm not sure you get notified of edits and the timing wasn't perfectly clear. |
daxian-dbw
approved these changes
Jun 20, 2018
Collaborator
Author
|
Looks like the test failure is |
Collaborator
Author
|
Not sure if that can be fixed in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #6919: Removes the
MapSecurityZoneWithUrlmonmethod and the native interface it uses.MapSecurityZoneWithUrlmonuses an unsupported API call, and this ensures we use a supported API to improve quality.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests