Updates to build for Alpine#7139
Conversation
f797b2a to
4e1b74d
Compare
src/libpsl-native/src/setdate.cpp
Outdated
There was a problem hiding this comment.
If we eventually move to a dotnet api, I don't think it's worth the effort to change to stime now. I need this change as the native build portion for Alpine fails here.
4e1b74d to
f160cea
Compare
There was a problem hiding this comment.
Minor nit: Are the white space diffs really needed?
There was a problem hiding this comment.
Consistent 4 spaces indentation (was copied from build.psm1)
|
The intent for alpine is to always have a separate alpine build? |
|
Filed issue to figure out Alpine Linux release #7167 |
|
I think it's fine to have just an Alpine docker image w/ PSCore6 |
|
I should change the runtime to |
added `set -e` to have it fail immediately on error
f160cea to
d95c617
Compare
|
Note that for |
This reverts commit 7d72e38.
PR Summary
setdate.cpp was incorrectly assigning an int to a struct, fixed to initialize struct zero'd
update the typegen project in the bash script
added some help text at top of script for someone trying to build it
updated runtime to linux-musl-x64 instead of linux-x64 as Alpine distro uses the musl libc libraries instead of glibc which is used by most distros.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests