Codestin Search App

djbuch · 2025-10-26T08:55:16Z

Questions	Answers
Branch?	develop
Description?	Fixed routing issue where using `match()` instead of `matchRequest()` caused the full Request object not to be passed to the router. This resulted in `Symfony\Component\Routing\Matcher\Dumper\CompiledUrlMatcherTrait` generating a "pseudo" request without headers, breaking route conditions that rely on request properties (e.g., `request.isXmlHttpRequest()` on the `admin_emails_send_test` route).
Type?	bug fix
Category?	CO
BC breaks?	no
Deprecations?	no
How to test?	1. Navigate to the email configuration page in the Back Office in a multishop environment 2. Try to send a test email using the AJAX request 3. Verify that the request is properly handled and the `isXmlHttpRequest()` condition is correctly evaluated 4. Check that routes with request-based conditions (like header checks) work as expected
UI Tests	https://github.com/SiraDIOP/ga.tests.ui.pr/actions/runs/21753389591
Fixed issue or discussion?	#37572, #39991
Related PRs
Sponsor company	Web Premiere

Codencode · 2025-11-19T15:56:31Z

Hi @djbuch,
your solution has a few issues, do you think you can fix them?
I'm asking because I wanted to test it and see if we can include it directly in the 9.0.x branch.

[Edit]
I ran a test - if you restore the $router parameter to what it was before, meaning you declare it as Symfony\Component\Routing\RouterInterface, the issue should be resolved and your solution should work.

djbuch · 2025-11-20T08:43:15Z

Hello, I made the change you said, let's wait and see the check results.

[Edit]
But I think we will have a problem since RouterInterface doesn't define matchRequest but this is the core change needed in this bug fix

Codencode · 2025-11-20T08:50:17Z

Hello, I made the change you said, let's wait and see the check results.

[Edit] But I think we will have a problem since RouterInterface doesn't define matchRequest but this is the core change needed in this bug fix

Okay, even though I tested it quickly locally and it works, let's wait for the tests to be sure/safe

djbuch · 2025-11-20T08:56:15Z

Yes the PHPStan tests failed

Error: Call to an undefined method Symfony\Component\Routing\RouterInterface::matchRequest().

Line src/PrestaShopBundle/EventListener/Admin/Context/ShopContextSubscriber.php

365 Call to an undefined method
Symfony\Component\Routing\RouterInterface::matchRequest().

Codencode · 2025-11-20T09:33:02Z

@djbuch
Okay, sorry 🙏, you're right, that's clear.

You could try it this way:
Reset the type of the $router parameter to Symfony\Component\Routing\Router
and then here

PrestaShop/app/config/admin/services.yml

Line 61 in 8ab6eb7

PrestaShopBundle\EventListener\Admin\Context\ShopContextSubscriber: ~

you can replace PrestaShopBundle\EventListener\Admin\Context\ShopContextSubscriber: ~ with:

  PrestaShopBundle\EventListener\Admin\Context\ShopContextSubscriber:
    autowire: true
    autoconfigure: true
    arguments:
      $router: '@router'

Let's check if it doesn't throw an error anymore, and then we'll ask the others for confirmation too.

Updated ShopContextSubscriber to enable autowiring and autoconfiguration.

kpodemski · 2025-11-20T10:13:45Z

Hello

I checked the problem, and the code below helped:

$controller = $request->attributes->get('_controller');
if (!$controller || !str_contains($controller, '::')) {
    return null;
}

Could you guys check?

djbuch · 2025-11-20T10:14:50Z

@kpodemski where should this code go ?

kpodemski · 2025-11-20T10:15:46Z

@djbuch

I haven't tested other bugs that were reported by @Codencode, I've only tested sending emails :)

If that works, then it also requires removing RouterInterface and adapting tests if needed

djbuch · 2025-11-20T10:27:21Z

But the problem here is in the matching of the route. Because of "request.isXmlHttpRequest()" in the route definition.

kpodemski · 2025-11-20T10:42:58Z

@djbuch I'm not sure about that, to me the problem was a mismatch in the route. After applying the changes I don't have any errors mentioned by @Codencode

Codencode · 2025-11-20T10:43:28Z

@djbuch

I haven't tested other bugs that were reported by @Codencode, I've only tested sending emails :)

If that works, then it also requires removing RouterInterface and adapting tests if needed

@kpodemski this solution works, I tested it for the cases that were causing issues and it's ok.
@djbuch it's also less impactful, I would take it into consideration!

djbuch · 2025-11-20T10:59:55Z

@kpodemski yes but the missmatch is because of request.isXmlHttpRequest(), with your code we just don't get the ShopContext from the route.

But the route exists, it is defined so it should be found. You can see that if you remove the condition request.isXmlHttpRequest() on the route definition the original code works, but this is the problem if we want the condition ton work we need to pass all the request to the match, not only a mocked request as it is done with ->match($request->getPathInfo())

[EDIT] : Did you try it in multishop context ?

jolelievre · 2025-11-20T12:47:18Z

        private readonly ShopConfigurationInterface $configuration,
        private readonly MultistoreFeature $multistoreFeature,
-        private readonly RouterInterface $router,
+        private readonly Router $router,


I think you should be able to replace this with RequestMatcherInterface the interface that implements the method you need. And the @router service correctly implements it

As much as possible we should favor using interfaces instead of explicit classes

Hello I already tried that : 4228f42 but the check failed

Ok tried again and with forcing the argument this time, let's see

jolelievre · 2025-11-20T12:49:04Z

+  PrestaShopBundle\EventListener\Admin\Context\ShopContextSubscriber:
+    autowire: true
+    autoconfigure: true
+    arguments:
+      $router: '@router'


The autowire and autoconfigure are already set as default values on this file (at the top of the file), so in theory you don't need to change this service definition

The autowiring should also be able to automatically inject the @router service (also check my other comment about using the appropriate interface) If by lack of chance the DI doesn't inject the service you expect to you can at most limit this modifications to only the arguments part

@jolelievre
Hi Jonathan,
If we don't pass the $router: '@router' parameter to the service, we get this error:

Cannot autowire service "PrestaShopBundle\EventListener\Admin\Context\ShopContextSubscriber": argument "$router" of method "__construct()" references class "Symfony\Component\Routing\Router" but no such service exists. Try changing the type-hint to one of its parents: interface "Symfony\Component\Routing\RouterInterface", interface "Symfony\Component\Routing\RequestContextAwareInterface", interface "Symfony\Component\Routing\Generator\UrlGeneratorInterface", or interface "Symfony\Component\Routing\Matcher\UrlMatcherInterface".

So apparently, the system can't inject Symfony\Component\Routing\Router, which is why I suggested modifying the service definition.

You're absolutely right that we can avoid re-adding autowire and autoconfigure - I was the one who led @djbuch to make that mistake.

Hello, tried without, and I need the arguments part. But as it is written for some other Services forcing arguments in the file I think I should keep

autowire: true autoconfigure: true

ok my bad, let's go with then

jolelievre · 2025-11-20T12:54:16Z

Hi guys, the fix seems legit I didn't go in depth into the router matchRequest method but I understand the idea behind it and it does make sense that the full request will give better matching for advanced routing configuration that just passing the path

I just commented on how this could be done in a cleaner way by using RequestMatcherInterface , didn't test it but it should do the job and still keep clean code

Added autowiring and arguments for ShopContextSubscriber.

jolelievre · 2025-11-20T14:22:25Z

    {
        try {
-            $routeInfo = $this->router->match($request->getPathInfo());
+            $routeInfo = $this->router->matchRequest($request);


We discussed about this with @kpodemski and his approach is also interesting:

$controller = $request->attributes->get('_controller');

because this way of retrieving the controller is faster BUT it requires the RouterListener to have been executed as it's the one that will set this attribute. The trick thing here is that this subscriber is executed twice:

once before the router

once after the router

So we thought maybe both solutions could be mixed, to combine both performance and stability, something like:

// Try to get the controller already set on the request (if RouterListener was executed) $controller = $request->attributes->get('_controller'); if (empty($controller)) { // If the attribute is not present yet we handle the matching ourselves and get the controller via routing info $routeInfo = $this->router->matchRequest($request); $controller = $routeInfo['_controller']; }

OK with that, I added these lines

jolelievre · 2025-11-20T21:12:54Z

+  PrestaShopBundle\EventListener\Admin\Context\ShopContextSubscriber:
+    autowire: true
+    autoconfigure: true
+    arguments:
+      $router: '@router'


ok my bad, let's go with then

jolelievre · 2025-11-20T21:13:48Z

    }

-    private function mockRouter(): RouterInterface|MockObject
+    private function mockRouter(): Router|MockObject


Can you try using the interface please as well? It should work

OK I did the change, seems to work

jolelievre

Thanks @djbuch and @kpodemski

Codencode · 2025-11-20T13:51:50Z

+  PrestaShopBundle\EventListener\Admin\Context\ShopContextSubscriber:
+    autowire: true
+    autoconfigure: true
+    arguments:
+      $router: '@router'


@jolelievre
Hi Jonathan,
If we don't pass the $router: '@router' parameter to the service, we get this error:

Cannot autowire service "PrestaShopBundle\EventListener\Admin\Context\ShopContextSubscriber": argument "$router" of method "__construct()" references class "Symfony\Component\Routing\Router" but no such service exists. Try changing the type-hint to one of its parents: interface "Symfony\Component\Routing\RouterInterface", interface "Symfony\Component\Routing\RequestContextAwareInterface", interface "Symfony\Component\Routing\Generator\UrlGeneratorInterface", or interface "Symfony\Component\Routing\Matcher\UrlMatcherInterface".

So apparently, the system can't inject Symfony\Component\Routing\Router, which is why I suggested modifying the service definition.

You're absolutely right that we can avoid re-adding autowire and autoconfigure - I was the one who led @djbuch to make that mistake.

kpodemski · 2026-03-14T07:13:32Z

Hello @djbuch

Could you rebase on 9.1.x branch? I'm not sure what happened, but this PR is still in QA, and we'd love to have it as soon as possible.

Change matching method

0720056

djbuch requested a review from a team as a code owner October 26, 2025 08:55

github-project-automation Bot added this to PR Dashboard Oct 26, 2025

github-project-automation Bot moved this to Ready for review in PR Dashboard Oct 26, 2025

ps-jarvis added develop Branch Bug fix Type: Bug fix labels Oct 26, 2025

djbuch added 5 commits October 26, 2025 10:05

Rename mock method from 'match' to 'matchRequest'

3a5f513

Update mockRouter method to include matchRequest

04ef5a8

Refactor mockRouter to use RequestMatcherInterface

f1f27f8

Replace RouterInterface with RequestMatcherInterface

4228f42

Change mockRouter to use Router instead of RequestMatcher

6dbe80d

Progi1984 linked an issue Oct 26, 2025 that may be closed by this pull request

Multistore - Send test email doesn't work #37572

Open

2 tasks

Update ShopContextSubscriber.php

f7ba1ad

Change Router type to RouterInterface in ShopContextSubscriber

85b9672

djbuch added 4 commits November 20, 2025 10:42

Change RouterInterface to Router in ShopContextSubscriber

22c3606

Modify ShopContextSubscriber configuration

7ddd95d

Updated ShopContextSubscriber to enable autowiring and autoconfiguration.

Fix indentation for LanguageContextSubscriber

6aa2a38

Remove trailing space in services.yml

36905e8

jolelievre reviewed Nov 20, 2025

View reviewed changes

djbuch added 4 commits November 20, 2025 14:47

Refactor ShopContextSubscriber configuration

60a92d3

Replace Router with RequestMatcherInterface in ShopContextSubscriber

bd80b85

Configure ShopContextSubscriber with autowire and arguments

8bc26a7

Added autowiring and arguments for ShopContextSubscriber.

Fix indentation in services.yml for router argument

6d99e80

jolelievre reviewed Nov 20, 2025

View reviewed changes

Refactor controller retrieval in ShopContextSubscriber

d39e730

jolelievre reviewed Nov 20, 2025

View reviewed changes

Change router mock to use RequestMatcherInterface

ff6d125

jolelievre approved these changes Nov 21, 2025

View reviewed changes

kpodemski approved these changes Nov 21, 2025

View reviewed changes

ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Nov 21, 2025

ps-jarvis moved this from Ready for review to To be tested in PR Dashboard Nov 21, 2025

Codencode approved these changes Nov 21, 2025

View reviewed changes

prestashop-issue-bot Bot added the Topwatchers Backlog prioritization: issue reported & followed by +6 people label Nov 21, 2025

Progi1984 added this to the 9.1.0 milestone Nov 24, 2025

Progi1984 modified the milestones: 9.1.0, 9.2.0 Dec 15, 2025

SiraDIOP self-assigned this Feb 6, 2026

kpodemski closed this Mar 14, 2026

github-project-automation Bot moved this from To be tested to Closed in PR Dashboard Mar 14, 2026

kpodemski reopened this Mar 14, 2026

github-project-automation Bot moved this from Closed to Reopened in PR Dashboard Mar 14, 2026

kpodemski changed the title ~~[CO] Change matching method in ShopContextSubscriber~~ Change matching method in ShopContextSubscriber Mar 14, 2026

kpodemski added Waiting for author Status: action required, waiting for author feedback and removed Waiting for QA Status: action required, waiting for test feedback labels Mar 14, 2026

ps-jarvis moved this from Reopened to Waiting for author in PR Dashboard Mar 14, 2026

Merge branch 'PrestaShop:develop' into patch-69

61671f2

Conversation

djbuch commented Oct 26, 2025 • edited by SiraDIOP Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Codencode commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

djbuch commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Codencode commented Nov 20, 2025

Uh oh!

djbuch commented Nov 20, 2025

Uh oh!

Codencode commented Nov 20, 2025

Uh oh!

kpodemski commented Nov 20, 2025

Uh oh!

djbuch commented Nov 20, 2025

Uh oh!

kpodemski commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

djbuch commented Nov 20, 2025

Uh oh!

kpodemski commented Nov 20, 2025

Uh oh!

Codencode commented Nov 20, 2025

Uh oh!

djbuch commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jolelievre commented Nov 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jolelievre left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kpodemski commented Mar 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

djbuch commented Oct 26, 2025 •

edited by SiraDIOP

Loading

Codencode commented Nov 19, 2025 •

edited

Loading

djbuch commented Nov 20, 2025 •

edited

Loading

kpodemski commented Nov 20, 2025 •

edited

Loading

djbuch commented Nov 20, 2025 •

edited

Loading