Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make the getters of Edit commands nullable for Attachment, Country and Zone#41470

Open
Quetzacoalt91 wants to merge 1 commit into
PrestaShop:developfrom
Quetzacoalt91:make-edit-command-getters-nullable
Open

Make the getters of Edit commands nullable for Attachment, Country and Zone#41470
Quetzacoalt91 wants to merge 1 commit into
PrestaShop:developfrom
Quetzacoalt91:make-edit-command-getters-nullable

Conversation

@Quetzacoalt91
Copy link
Copy Markdown
Member

@Quetzacoalt91 Quetzacoalt91 commented May 14, 2026

Questions Answers
Branch? develop
Description? Update the getters of Edit commands with a nullable return type, so we don't have to always provide specific properties when updating a Country, a Zone or an Attachment (The concerned domains). My understanding is that updating the signature of the methods is considered as BC, if that's a thing on this part of the project. If anyone can confirm (or not) this assessment, that would be nice.
Type? bug fix
Category? CO
BC breaks? yes
Deprecations? No
How to test? Follow the description of #41469
UI Tests Enjoy
Fixed issue or discussion? Fixes #41469
Related PRs /
Sponsor company @PrestaShopCorp

@Quetzacoalt91 Quetzacoalt91 self-assigned this May 14, 2026
@Quetzacoalt91 Quetzacoalt91 requested a review from a team as a code owner May 14, 2026 15:49
@Quetzacoalt91 Quetzacoalt91 added Bug fix Type: Bug fix BC break Type: Introduces a backwards-incompatible break labels May 14, 2026
@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard May 14, 2026
@ps-jarvis ps-jarvis added develop Branch and removed BC break Type: Introduces a backwards-incompatible break labels May 14, 2026
@github-actions github-actions Bot added this to the 9.2.0 milestone May 14, 2026
@ps-jarvis ps-jarvis added the BC break Type: Introduces a backwards-incompatible break label May 14, 2026
@Quetzacoalt91 Quetzacoalt91 changed the title Make the getters of Edit commands nullable for Attachement, Country and Zone Make the getters of Edit commands nullable for Attachment, Country and Zone May 14, 2026
Copy link
Copy Markdown
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's blocking the Admin API, then IMHO we should approve it.

cc @jolelievre

@Quetzacoalt91 there's no red test in the UI tests, could you restart it? it doesn't seem to be related, but let's try ;)

@ps-jarvis ps-jarvis moved this from Ready for review to Need 2nd approval in PR Dashboard May 23, 2026
@kpodemski kpodemski added the Needs documentation Needs an update of the developer documentation label May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BC break Type: Introduces a backwards-incompatible break Bug fix Type: Bug fix develop Branch Needs documentation Needs an update of the developer documentation

Projects

Status: Need 2nd approval

Development

Successfully merging this pull request may close these issues.

Admin API - Getters of properties in edit commands should be nullable

3 participants