Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoid bad URL on invalid media with media servers enabled and CCC disabled#41509

Open
gross-nvs wants to merge 1 commit into
PrestaShop:9.1.xfrom
gross-nvs:fix/invalid-media-url-for-missing-assets
Open

Avoid bad URL on invalid media with media servers enabled and CCC disabled#41509
gross-nvs wants to merge 1 commit into
PrestaShop:9.1.xfrom
gross-nvs:fix/invalid-media-url-for-missing-assets

Conversation

@gross-nvs
Copy link
Copy Markdown
Contributor

Questions Answers
Branch? 9.1.x
Description? When CCC is disabled and media servers are in use, missing js/css files will generate an invalid URI (as getFullPath will return false and ternary condition will produce an empty string as a concatenation result). Result must be tested before to avoid generating an URI known to lead to a 404.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
How to test? Set up a media server, disable CCC, without the path you'll see / being requested on your media server once as a css file, and once a a js file. With the patch both calls are avoided.
UI Tests No UI changes
Fixed issue or discussion?
Related PRs
Sponsor company Novius

@gross-nvs gross-nvs requested a review from a team as a code owner May 19, 2026 16:21
@github-project-automation github-project-automation Bot moved this to Ready for review in PR Dashboard May 19, 2026
@ps-jarvis
Copy link
Copy Markdown

Hi, thanks for this contribution!

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@ps-jarvis ps-jarvis added Bug fix Type: Bug fix 9.1.x Branch labels May 19, 2026
@github-actions github-actions Bot added this to the 9.1.3 milestone May 19, 2026
@kpodemski kpodemski modified the milestone: 9.1.3 May 20, 2026
@ps-jarvis ps-jarvis moved this from Ready for review to Need 2nd approval in PR Dashboard May 20, 2026
@Progi1984 Progi1984 modified the milestones: 9.1.3, 9.1.4 May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.1.x Branch Bug fix Type: Bug fix

Projects

Status: Need 2nd approval

Development

Successfully merging this pull request may close these issues.

4 participants